test: run tests before committing, in addition to pretty-quick#64
Merged
wagoid merged 1 commit intowagoid:masterfrom Dec 3, 2020
jdbruijn:test/commit
Merged
test: run tests before committing, in addition to pretty-quick#64wagoid merged 1 commit intowagoid:masterfrom jdbruijn:test/commit
pretty-quick#64wagoid merged 1 commit intowagoid:masterfrom
jdbruijn:test/commit
Conversation
wagoid
approved these changes
Nov 29, 2020
Owner
wagoid
left a comment
wagoid
left a comment
There was a problem hiding this comment.
Thanks for the update! You now have conflicts on package.json, could you fix them?
| @@ -0,0 +1,4 @@ | |||
| module.exports = { | |||
| '*.{ts,tsx,vue,css,less,scss,html,htm,md,markdown}': 'prettier --write', | |||
Owner
There was a problem hiding this comment.
The project doesn't have Typescript files, are they included here to be future proof?
Collaborator
Author
There was a problem hiding this comment.
Yes, these are the supported formats of Prettier so I just included all of them. It doesn't matter if some formats are not, yet, used in this repo.
`pretty-quick` is not needed any more as lint-staged can run prettier with just the staged files, thus getting the same behaviour. Closes #60.
Collaborator
Author
|
@wagoid Conflicts are resolved now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pretty-quickis not needed any more as lint-staged can run prettier with just the staged files, thus getting the same behaviour.Closes #60.