Add specific permissions to workflows under .github/workflows#231
Merged
wagoid merged 2 commits intowagoid:masterfrom Sep 11, 2021
step-security:master
Merged
Add specific permissions to workflows under .github/workflows#231wagoid merged 2 commits intowagoid:masterfrom step-security:master
wagoid merged 2 commits intowagoid:masterfrom
step-security:master
Conversation
jdbruijn
approved these changes
Sep 10, 2021
Owner
|
Awesome initiative @varunsh-coder! LGTM |
Contributor
Author
|
Thanks @wagoid! I just started on this and I am eager to get some early adopters. Request you to please try out the app on some of your repos that have workflow files. I can walk you through the process if you want. It should only take couple of minutes. Just tag me on this thread if you need help installing the app or if it does not work as expected, and I will look into it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds specific permissions to the existing ci.yml workflow under .github/workflows.
Background
I am the founder of Step Security, and have implemented a GitHub App to automatically restrict permissions for the GITHUB_TOKEN in workflows. This is a security best practice as per the GitHub Actions hardening guide.
I am trying the App out on important public repositories, by forking them, installing the App on the fork, and manually creating PRs with the fixed workflows. The App automatically fixes permissions when a new PR is created that changes a workflow, so feel free to install it for future workflows, or try it out on other repos. It will stay free for public repos...
I have manually reviewed the changes, and they do look good to me. If something looks off, please let me know. If you have feedback, would love to hear it. Unfortunately, the other workflow could not be fixed, since it uses your action as a local action (./) which is not supported as of now. Thanks!