Conversation
This will help upgrading dependencies to new versions that are exported as ESM. BREAKING CHANGE: Node.js version used on the action updated from 12 to 16
Some packages were updated to versions that now use ECMAScript modules, so this repo was updated to use ES modules using Node.js built-in support. Update was done using the great guide from @sindresorhus: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
wagoid
commented
Jul 7, 2021
| "no-process-exit": "off", | ||
| "node/no-unpublished-require": "off" | ||
| "node/no-unpublished-require": "off", | ||
| "node/no-unpublished-import": "off", |
Owner
Author
There was a problem hiding this comment.
Needed to disable this and ES syntax rules for now, they're not fully supporting ESM syntax yet. From docs:
⚠️ ECMAScript 2015 (ES6) does not define the lookup logic and Node does not support modules yet. So this rule spec might be changed in future.
wagoid
commented
Jul 7, 2021
| @@ -0,0 +1,12 @@ | |||
| { | |||
Owner
Author
There was a problem hiding this comment.
standard-version doesn't support .cjs yet, so I updated to use the .json version instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR got a bit big due to the update to support ES modules, but thoe updates are mostly about import syntax and renamed files.