Skip to content

README: Add a link to the commitlink project#152

Merged
wagoid merged 1 commit intowagoid:masterfrom
sschuberth:patch-1
May 4, 2021
Merged

README: Add a link to the commitlink project#152
wagoid merged 1 commit intowagoid:masterfrom
sschuberth:patch-1

Conversation

@sschuberth
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@jdbruijn jdbruijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue it should link to https://commitlint.js.org/#/, which is their main page as far as I know.

@sschuberth sschuberth requested a review from jdbruijn May 4, 2021 09:17
Copy link
Copy Markdown
Owner

@wagoid wagoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! One small detail, your commit message needs to have a valid subject. So instead of README: you can use docs: or docs(README):
You can see more details about the lint failure here: https://github.com/wagoid/commitlint-github-action/pull/152/checks?check_run_id=2499490935

@sschuberth sschuberth requested a review from wagoid May 4, 2021 10:20
@wagoid
Copy link
Copy Markdown
Owner

wagoid commented May 4, 2021

@sschuberth
Copy link
Copy Markdown
Contributor Author

So we need to replace by docs(readme)

Done.

@wagoid
Copy link
Copy Markdown
Owner

wagoid commented May 4, 2021

Last one! add instead of Add haha

@sschuberth
Copy link
Copy Markdown
Contributor Author

Last one! add instead of Add haha

Already did that in parallel. Actually, this was a nice showcase, and probably showed me that these conventions are not for us 😉

@wagoid
Copy link
Copy Markdown
Owner

wagoid commented May 4, 2021

@sschuberth you can configure them, and remove whatever conventions you think is not fit for you. For example, in the company I work we allow any scope case so that we can put jira tickets in the scope. You can set your commitlint config file to make things as loose as you want 🚀

@wagoid wagoid merged commit b9ec86a into wagoid:master May 4, 2021
@sschuberth sschuberth deleted the patch-1 branch May 4, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants