Added plugin with jira rules for commitlint-config-jira#14
Merged
wagoid merged 1 commit intowagoid:masterfrom Nov 24, 2019
Merged
Conversation
wagoid
requested changes
Nov 23, 2019
Owner
wagoid
left a comment
wagoid
left a comment
There was a problem hiding this comment.
hi @jotanavarro, thank you for fixing this issue! The changes look good to me, there's just one thing: could you update your commit message to use the conventional commits pattern?
It would be something like this:
fix: added plugin with jira rules for `commitlint-config-jira`
Also updated the `commitlint-config-jira` to its latest version.
Sorry for CI not telling you that, the reason why our current tests didn't show lint errors in your message is because the action was always working on CI due to a bug in the workflow I introduced recently. I just fixed it here so if you sync with master again you will have a CI that is not "incorrectly passing"
jotanavarro
force-pushed
the
Adding-commitlint-jira-plugin-for-rules
branch
3 times, most recently
from
2a2f674 to
3bb0d67
Compare
Added the `commitlint-plugin-jira-rules` package. Also updated the `commitlint-config-jira` to its latest version.
jotanavarro
force-pushed
the
Adding-commitlint-jira-plugin-for-rules
branch
from
3bb0d67 to
6cede4b
Compare
Contributor
Author
|
Now using the more verbose commit message policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin containing rules to be used by
commitlint-config-jirawas missing from thepackage.json. This means that when extending['jira']in thecommitlint.config.jsit was always failing due to unknown rules.This fixes #13 and allows easy usage of the
commitlint-config-jira.