ci: run npm ci to install and ignore scripts#104
Merged
Conversation
`npm ci` is meant to be used in CI environments and the scripts are ignored to prevent e.g. Husky from being installed in the CI environment. See https://docs.npmjs.com/cli/v7/commands/npm-ci.
Collaborator
Author
|
Also note that I think this will fix the CI release issues on master, like: https://github.com/wagoid/commitlint-github-action/runs/1981465369?check_suite_focus=true I think those would have started failing after the Husky v5 update, but wasn't then due to the the configuration being invalid. |
wagoid
approved these changes
Feb 25, 2021
Owner
wagoid
left a comment
wagoid
left a comment
There was a problem hiding this comment.
LGTM! @jdbruijn so we should also add --ignore-scripts to the Dockerfile, right?
Collaborator
Author
Yeah! I'll update in a sec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm ciis meant to be used in CI environments and the scripts are ignored to prevent e.g. Huskyfrom being installed in the CI environment. See https://docs.npmjs.com/cli/v7/commands/npm-ci.