Skip to content

fix: update @commitlint/config-conventional to latest version#10

Merged
wagoid merged 2 commits intowagoid:masterfrom
vidavidorra:master
Oct 21, 2019
Merged

fix: update @commitlint/config-conventional to latest version#10
wagoid merged 2 commits intowagoid:masterfrom
vidavidorra:master

Conversation

@vidavidorra
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Owner

@wagoid wagoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @vidavidorra!! Just a minor comment about exact verion and that's all 🚀

package.json Outdated
"@actions/github": "1.1.0",
"@commitlint/config-angular": "8.2.0",
"@commitlint/config-conventional": "7.6.0",
"@commitlint/config-conventional": "^8.2.0",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using exact versions in dependencies, could you update this to 8.2.0?

Copy link
Copy Markdown
Contributor Author

@vidavidorra vidavidorra Oct 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I didn't notice that in the package.json before. Fixed that in the added commit. You should probably squash merge them to keep the git log clean ;)

Also to let you know, some other packages are outdated as well. I could update those too but don't have a good way of testing your stuff still works correctly (there is no npm run test or something like that as far as I could see), therefore I haven't done those as I can't check the impact.

Package                     Current  Wanted  Latest  Location
@actions/core                 1.1.1   1.1.1   1.2.0  commitlint-github-action
commitlint-config-jira        1.0.9   1.0.9  1.0.11  commitlint-github-action
conventional-changelog-cli   2.0.23  2.0.23  2.0.25  commitlint-github-action
husky                         3.0.7   3.0.7   3.0.9  commitlint-github-action
pretty-quick                 1.11.1  1.11.1   2.0.0  commitlint-github-action

and there are 10 security vulnerabilities (npm audit) that cannot be fixed automatically.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently I don't have much test cases covered (just some scenarios with the current workflows but no more than that). Once I have more time I will add tests and check the new versions, thanks for the heads up!
Regarding squash merge, I prefer merge commits instead of squashing. I prefer what people call a "messy history" because it is more complete and shows all atomic changes to the repo 🙂
About the security vulnerabilities, don't worry about them. All of the Machine-In-The-Middle scenarios happen in some lerna commands that are not used by this action (like @lerna/publish), so all good 🚀

@vidavidorra vidavidorra requested a review from wagoid October 20, 2019 19:20
Copy link
Copy Markdown
Owner

@wagoid wagoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wagoid wagoid merged commit 813e6e2 into wagoid:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants