packages/docs/test/view/visual-line.test.ts (1)

52-55: Consider adding an out-of-bounds offset test.

The current tests don't verify behavior when offset exceeds the block's character count. If findVisualLine should handle this gracefully (e.g., clamp to last line), a test would document that behavior.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/docs/test/view/visual-line.test.ts` around lines 52 - 55, Add a test
in visual-line.test.ts that calls findVisualLine with an offset greater than the
block's length (e.g., offset beyond 25) to assert graceful handling: expect it
to clamp to the last visual line (use the same lb and blockId: 'b1') and return
lineIndex equal to the last line, totalLines unchanged, lineStart at the last
line's start and lineEnd equal to the block's length; this documents and
verifies findVisualLine's out-of-bounds behavior.

packages/docs/src/view/visual-line.ts (2)

36-48: Fallback code recomputes values already available in the loop.

The fallback block recalculates lastStart by iterating through all lines again, but this value equals charsBefore at loop exit. Consider capturing it before the loop ends or returning early to avoid this redundancy.

♻️ Proposed simplification

   let charsBefore = 0;
+  let lastLineStart = 0;
+  let lastLineEnd = 0;
   for (let i = 0; i < lb.lines.length; i++) {
     let lineChars = 0;
     for (const run of lb.lines[i].runs) {
       lineChars += run.charEnd - run.charStart;
     }
     const lineStart = charsBefore;
     const lineEnd = charsBefore + lineChars;
+    lastLineStart = lineStart;
+    lastLineEnd = lineEnd;
     const isLastLine = i === lb.lines.length - 1;
     if (pos.offset >= lineStart && (pos.offset < lineEnd || (isLastLine && pos.offset <= lineEnd))) {
       return { lineIndex: i, totalLines: lb.lines.length, lineStart, lineEnd };
     }
     charsBefore = lineEnd;
   }
 
   // Fallback: last line
-  const lastLine = lb.lines.length - 1;
-  let lastStart = 0;
-  for (let i = 0; i < lastLine; i++) {
-    for (const run of lb.lines[i].runs) {
-      lastStart += run.charEnd - run.charStart;
-    }
-  }
-  let lastChars = 0;
-  for (const run of lb.lines[lastLine].runs) {
-    lastChars += run.charEnd - run.charStart;
-  }
-  return { lineIndex: lastLine, totalLines: lb.lines.length, lineStart: lastStart, lineEnd: lastStart + lastChars };
+  return { lineIndex: lb.lines.length - 1, totalLines: lb.lines.length, lineStart: lastLineStart, lineEnd: lastLineEnd };
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/docs/src/view/visual-line.ts` around lines 36 - 48, The fallback
recomputes lastStart by iterating lines again; instead use the accumulated value
already tracked (charsBefore) when the loop exits or return early from the loop
where you detect the last line. Update the logic in the visual line calculation
to set lastStart = charsBefore (or return { lineIndex: lastLine, totalLines:
lb.lines.length, lineStart: charsBefore, lineEnd: charsBefore + lastChars })
instead of recomputing over lb.lines, referencing the variables lb.lines,
lastLine, lastChars, lastStart and the existing charsBefore accumulator in the
surrounding function.

---

30-34: Consider simplifying the boundary condition.

The condition on line 30 is correct but complex. A brief inline comment explaining the inclusive end check for the last line would improve readability.

     const isLastLine = i === lb.lines.length - 1;
+    // Last line uses inclusive end (<=) since cursor can be at text end
     if (pos.offset >= lineStart && (pos.offset < lineEnd || (isLastLine && pos.offset <= lineEnd))) {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/docs/src/view/visual-line.ts` around lines 30 - 34, The if-condition
comparing pos.offset against lineStart/lineEnd is correct but complex; simplify
it by making the end check uniformly use < lineEnd for normal lines and <=
lineEnd only when isLastLine (e.g., compute a local maxOffset = isLastLine ?
lineEnd : lineEnd - 1 or use a boolean endInclusive = isLastLine and then test
pos.offset <= maxOffset), and add a short inline comment by the check explaining
that the last line uses an inclusive end check to allow offsets equal to
lineEnd; target the existing condition that uses pos.offset, lineStart, lineEnd,
and isLastLine in this file to apply the change.