packages/frontend/src/components/user-presence.tsx (1)

85-92: Unify avatar border styling to prevent future drift.

The peer border color logic is duplicated, and bg-background is present on Line 86 but missing on Line 146. Extracting shared style logic keeps both avatar variants consistent.

♻️ Suggested refactor

+  const getPeerBorderColor = (user: (typeof users)[number]) =>
+    user.isCurrentUser
+      ? undefined
+      : getPeerCursorColor(resolvedTheme, user.clientID);
+
   const renderAvatar = (user: (typeof users)[number]) => {
@@
             <Avatar
               className="h-8 w-8 border-2 bg-background"
               style={{
-                borderColor: user.isCurrentUser
-                  ? undefined
-                  : getPeerCursorColor(resolvedTheme, user.clientID),
+                borderColor: getPeerBorderColor(user),
               }}
             >
@@
                         <Avatar
-                          className="h-6 w-6 border-2"
+                          className="h-6 w-6 border-2 bg-background"
                           style={{
-                            borderColor: user.isCurrentUser
-                              ? undefined
-                              : getPeerCursorColor(resolvedTheme, user.clientID),
+                            borderColor: getPeerBorderColor(user),
                           }}
                         >

Also applies to: 145-152

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/frontend/src/components/user-presence.tsx` around lines 85 - 92, The
Avatar components duplicate border/background styling; extract a shared computed
style object (e.g., avatarBorderStyle) that sets borderColor to
user.isCurrentUser ? undefined : getPeerCursorColor(resolvedTheme,
user.clientID) and includes bg-background, then apply that object to both Avatar
usages (the one around Line ~85 and the one around Line ~146) to ensure
consistent border and background across variants; update any inline style
references to use the new shared variable so future changes stay unified.

packages/sheets/src/store/store.ts (1)

76-76: Extract a shared StorePresence type to avoid signature drift.

Line 76 duplicates a complex inline shape now repeated across store.ts, memory.ts, readonly.ts, and sheet.ts. A shared exported type will reduce future mismatch risk.

♻️ Proposed refactor

 export interface Store {
+  // Presence payload returned by collaboration-capable stores.
+  // `username` is optional because some clients may not publish it.
+  // `activeCell` remains required for cursor rendering.
+}
+
+export type StorePresence = {
+  clientID: string;
+  presence: { activeCell: string; username?: string };
+};
+
+export interface Store {
@@
-  getPresences(): Array<{ clientID: string; presence: { activeCell: string; username?: string } }>;
+  getPresences(): StorePresence[];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/sheets/src/store/store.ts` at line 76, Extract and export a shared
type named StorePresence that represents { clientID: string; presence: {
activeCell: string; username?: string } }, then replace the inline signature in
the getPresences declaration in store.ts with Array<StorePresence> and update
all other occurrences (memory.ts, readonly.ts, sheet.ts) to use StorePresence so
the shape is defined in one place and exported for reuse; ensure the new type is
exported from the module that previously declared the inline shape.

docs/tasks/active/20260323-peer-cursor-labels-todo.md (1)

15-15: Heading levels skip h2.

The document jumps from # Peer Cursor Name Labels Implementation Plan (h1) directly to ### Task 1 (h3), skipping h2. This violates markdown best practices and accessibility guidelines for document structure.

📝 Suggested fix

Either change task headings to h2:

-### Task 1: Widen Store presence type to include `username`
+## Task 1: Widen Store presence type to include `username`

Or add an h2 section wrapper:

 ---

+## Implementation Tasks
+
 ### Task 1: Widen Store presence type to include `username`

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/tasks/active/20260323-peer-cursor-labels-todo.md` at line 15, The
document skips from the H1 "Peer Cursor Name Labels Implementation Plan" to "###
Task 1: Widen Store presence type to include `username`" (H3); update the
heading structure by changing each task heading like "### Task 1: Widen Store
presence type to include `username`" to an H2 ("## Task 1: ...") or
alternatively insert a new H2 wrapper (e.g., "## Tasks" immediately after the
H1) and keep the existing task headings as H3, ensuring the heading hierarchy is
H1 → H2 → H3 for proper accessibility.

docs/design/peer-cursor-labels.md (1)

42-42: Documentation doesn't match implementation: text color is now luminance-based.

The design spec states text color is always #FFFFFF (white), but the implementation in overlay.ts uses getLabelTextColor() which selects black (#000000) or white (#FFFFFF) based on background luminance. This is a better approach for accessibility, but the documentation should be updated to reflect the actual behavior.

📝 Suggested doc update

-| Text color     | White (`#FFFFFF`)                                |
+| Text color     | Auto-contrast (white on dark, black on light)    |

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/design/peer-cursor-labels.md` at line 42, The docs state label text
color is always `#FFFFFF`, but the implementation in overlay.ts uses
getLabelTextColor() to pick `#000000` or `#FFFFFF` based on background luminance;
update docs/design/peer-cursor-labels.md to describe this adaptive behavior,
mentioning getLabelTextColor() and that text color is chosen (black or white)
depending on background luminance for accessibility rather than always white.

packages/sheets/src/view/overlay.ts (1)

37-44: getLabelTextColor assumes well-formed 6-digit hex color.

The function expects a hex color like #FF6B6B or FF6B6B. If a non-hex format is passed (CSS color name, rgb(), 3-digit hex), the substring parsing will produce incorrect results. Currently safe since getPeerCursorColor always returns hex, but consider adding validation or a comment noting this assumption.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/sheets/src/view/overlay.ts` around lines 37 - 44, getLabelTextColor
currently assumes a 6-digit hex string and will misparse other color formats;
update getLabelTextColor to validate and normalize input (accept leading '#',
expand 3-digit hex to 6-digit, and detect non-hex formats) and fall back to a
safe default color if validation fails, or add a concise comment documenting the
assumption and linking its use by getPeerCursorColor so future callers know the
hex-only contract; reference the getLabelTextColor function and its caller
getPeerCursorColor when making the change.