Fix overflow text disappearing on horizontal scroll by hackerwins · Pull Request #69 · wafflebase/wafflebase

hackerwins · 2026-03-22T12:46:56Z

Summary

When a cell contains long text that overflows into adjacent cells, scrolling right until the source cell leaves the viewport caused the overflowed text to vanish
Extended overflow detection range 20 columns to the left of the viewport in buildTextOverflowRenderData
Added supplementary render pass (3b) that draws text from off-screen anchor cells whose overflow reaches into the visible area

Test plan

Enter long text in A1 that overflows into B1, C1
Scroll right until A1 is off-screen — verify overflowed text in B1/C1 still renders
Test with freeze panes active (frozen columns + horizontal scroll)
Verify pnpm verify:fast passes (confirmed)

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved text overflow detection to identify overflow scenarios earlier in the rendering process.
- Enhanced rendering of text that extends beyond cell boundaries, especially when originating from cells outside the currently visible area.

When a cell contains long text that overflows into adjacent cells, scrolling right until the source cell leaves the viewport caused the overflowed text to vanish. The overflow detection loop only examined cells inside the visible column range, so off-screen anchors were never recorded. Extend the overflow scan 20 columns to the left of the viewport and add a supplementary render pass (3b) that draws text from off-screen anchor cells whose overflow reaches into the visible area. Co-Authored-By: Claude Opus 4.6 <[email protected]>

coderabbitai · 2026-03-22T12:47:08Z

📝 Walkthrough

Walkthrough

Modified text overflow detection in grid canvas rendering to start earlier horizontally and added a new render pass (Pass 3b) to handle overflow anchors positioned left of the visible viewport whose text spans into the displayed range. The change extends overflow text rendering logic while maintaining style resolution.

Changes

Cohort / File(s)	Summary
Text Overflow Rendering Enhancement `packages/sheets/src/view/gridcanvas.ts`	Extended text overflow detection by shifting column start calculation (`overflowColStart = Math.max(1, colStart - 20)`). Added Pass 3b render pass to draw overflow anchors positioned left of `colStart` when their computed `endCol` spans into the visible viewport. Calls `renderCellContent` with explicit `overflowEndCol` and `mergeSpan` parameters.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 A canvas redrawn with care so keen,
Overflow text now perfectly seen,
Pass 3b hops where anchors hide left,
Viewport gaps filled, no detail bereft!
Thirty lines dancing, rendering refined. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix overflow text disappearing on horizontal scroll' clearly and directly summarizes the main bug fix in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/text-overflow-on-horizontal-scroll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-22T12:48:54Z

Verification: verify:self

Result: ✅ PASS in 88.9s

Lane	Status	Duration
sheets:build	✅ pass	12.6s
verify:fast	✅ pass	43.8s
frontend:build	✅ pass	12.1s
verify:frontend:chunks	✅ pass	0.3s
backend:build	✅ pass	4.0s
cli:build	✅ pass	1.6s
verify:entropy	✅ pass	14.5s

Verification: verify:integration

Result: ✅ PASS

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/sheets/src/view/gridcanvas.ts`:
- Around line 485-493: Replace the fixed 20-column lookback when computing
overflowColStart with a leftward scan from colStart - 1 until you hit the first
blocking anchor (a non-empty cell, a merged cell boundary, or a visible border)
and use that column as overflowColStart before calling
buildTextOverflowRenderData; update the logic in gridcanvas (around
overflowColStart / buildTextOverflowRenderData usage) to iterate leftward
checking cell content, merge metadata and border flags instead of using
Math.max(1, colStart - 20) so off-screen anchors are found correctly regardless
of column widths or hidden columns.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ef383dd1-0fbb-4fdd-af13-6608e06700b0

📥 Commits

Reviewing files that changed from the base of the PR and between 999540b and a3f4c58.

📒 Files selected for processing (1)

packages/sheets/src/view/gridcanvas.ts

coderabbitai · 2026-03-22T12:53:09Z

+    // Extend the overflow detection range to the left so that text from
+    // off-screen cells that overflows into the visible area is still drawn.
+    const overflowColStart = Math.max(1, colStart - 20);
    const overflowData = this.buildTextOverflowRenderData(
      ctx,
      rowStart,
      rowEnd,
-      colStart,
+      overflowColStart,
      colEnd,


⚠️ Potential issue | 🟡 Minor

The 20-column lookback is still a correctness cap.

A value can legitimately overflow through more than 20 logical columns, especially with narrow or hidden columns, so anchors farther left will still disappear once scrolled past. Instead of a fixed lookback, consider walking left from colStart - 1 until you hit the first blocker (content, merge, or border) and using that as the only possible off-screen anchor.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@packages/sheets/src/view/gridcanvas.ts` around lines 485 - 493, Replace the fixed 20-column lookback when computing overflowColStart with a leftward scan from colStart - 1 until you hit the first blocking anchor (a non-empty cell, a merged cell boundary, or a visible border) and use that column as overflowColStart before calling buildTextOverflowRenderData; update the logic in gridcanvas (around overflowColStart / buildTextOverflowRenderData usage) to iterate leftward checking cell content, merge metadata and border flags instead of using Math.max(1, colStart - 20) so off-screen anchors are found correctly regardless of column widths or hidden columns.

coderabbitai Bot reviewed Mar 22, 2026

View reviewed changes

hackerwins merged commit cf0e97f into main Mar 23, 2026
3 checks passed

hackerwins deleted the fix/text-overflow-on-horizontal-scroll branch March 23, 2026 23:50

coderabbitai Bot mentioned this pull request Apr 18, 2026

Fix error-string center alignment and sync toolbar align state #136

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix overflow text disappearing on horizontal scroll#69

Fix overflow text disappearing on horizontal scroll#69
hackerwins merged 1 commit into
mainfrom
fix/text-overflow-on-horizontal-scroll

hackerwins commented Mar 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 22, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

github-actions Bot commented Mar 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

hackerwins commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

github-actions Bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Verification: verify:self

Verification: verify:integration

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hackerwins commented Mar 22, 2026 •

edited

Loading

coderabbitai Bot commented Mar 22, 2026 •

edited

Loading

github-actions Bot commented Mar 22, 2026 •

edited

Loading