packages/sheet/src/model/coordinates.ts (1)

345-360: Unreachable code path in absCol detection.

The ref.includes('!$') check on line 346 appears to be dead code. The regex on line 349 (^(\$?)([A-Za-z]+)(\$?)(\d+)$) will throw an error for any cross-sheet reference containing !, so this condition can never be true for a valid input that passes the regex check.

Looking at the call sites in shifting.ts, parseARef is always called on local references after the cross-sheet prefix has already been stripped (e.g., text.toUpperCase() where text excludes the sheet prefix).

🔧 Suggested simplification

 export function parseARef(ref: Sref): ARef {
-  const absCol = ref.startsWith('$') || ref.includes('!$');
+  const absCol = ref.startsWith('$');
   // Find the column-row boundary to detect row dollar sign.
   // After optional leading '$' and column letters, check for '$' before digits.
   const match = ref.match(/^(\$?)([A-Za-z]+)(\$?)(\d+)$/);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/sheet/src/model/coordinates.ts` around lines 345 - 360, The absCol
detection in parseARef incorrectly checks ref.includes('!$'), which is
unreachable because the regex /^(\$?)([A-Za-z]+)(\$?)(\d+)$/ used later rejects
any string containing '!', so remove the dead includes('!$') branch and compute
absCol solely from ref.startsWith('$'); update the attendant comment to state
that the code assumes any sheet prefix has been stripped before calling
parseARef and keep the existing regex-based validation and absRow handling
(match[3] === '$') intact.

packages/sheet/src/model/shifting.ts (1)

80-88: Consider extracting repeated abs marker spreading pattern.

The pattern for preserving absolute markers is repeated verbosely here and in several other places (shiftSref, shiftARef, relocateARef):

{ ...moved, ...(aref.absCol ? { absCol: true } : {}), ...(aref.absRow ? { absRow: true } : {}) }

This works correctly, but a small helper could reduce duplication and improve readability.

🔧 Optional helper to reduce repetition

/** Copies absCol/absRow flags from source ARef to a Ref */
function withAbsMarkers(ref: Ref, source: ARef): ARef {
  return {
    ...ref,
    ...(source.absCol ? { absCol: true } : {}),
    ...(source.absRow ? { absRow: true } : {}),
  };
}

Then usage becomes:

-result += toASref({ ...moved, ...(aref.absCol ? { absCol: true } : {}), ...(aref.absRow ? { absRow: true } : {}) });
+result += toASref(withAbsMarkers(moved, aref));

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/sheet/src/model/shifting.ts` around lines 80 - 88, The repeated
pattern that re-applies absolute markers ({ ...(aref.absCol ? { absCol: true } :
{}), ...(aref.absRow ? { absRow: true } : {}) }) should be extracted into a
small helper to reduce duplication and improve readability; add a function
(e.g., withAbsMarkers(ref: Ref, source: ARef): ARef) that returns { ...ref,
...(source.absCol ? { absCol: true } : {}), ...(source.absRow ? { absRow: true }
: {}) } and replace occurrences in this file where parseARef, moveRef and
toASref are combined (and similar sites in shiftSref, shiftARef, relocateARef)
to call withAbsMarkers(movedOrNewRef, originalARef) before passing to toASref.