Refresh slides toolbar visual baselines for #206#207
Merged
Conversation
Commit dd3ca28 added an explicit Select toggle and turned Shape into an icon-only toggle, forming a Select/Text/Shape exclusive group on the slides toolbar. The 8 baselines that capture that toolbar (and the full harness shots that contain it) drifted as a result, breaking verify-browser on main. Regenerated via `pnpm verify:browser:docker:update` so the rendering matches the CI Playwright container exactly. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (8)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Verification: verify:selfResult: ✅ PASS in 177.3s
Verification: verify:integrationResult: ✅ PASS |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hackerwins
added a commit
that referenced
this pull request
May 10, 2026
Adding 8 align + 2 distribute buttons to the slides formatting toolbar reflows every mobile slides harness scenario (toolbar height wraps differently) and shifts the dedicated slides-toolbar desktop capture. Same kind of refresh as PR #207 did for #206. 37 baselines updated: 33 slides mobile scenarios + 2 slides-toolbar desktop (light + dark.dark profile) + 4 root harness pages (`harness-visual.browser.{,desktop.dark,mobile,mobile.dark}.png`). Generated by `pnpm verify:browser:docker:update`. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
hackerwins
added a commit
that referenced
this pull request
May 11, 2026
Adds @wafflebase/slides as a third surface alongside Sheets and Docs, plus 53-shape library (Phase 1+2), adjustment handles for 9 pilot shapes (P3-A.1), live snap guides, align/distribute toolbar, themed authoring, and layout-change UI. Also ships Sheets cell comments (Phase B), docs peer-avatar caret jump, yorkie-js-sdk 0.7.8 upgrade, and CLI/REST API improvements (docs export imageFetcher, expired session refresh, REST docs split). Minor bump because slides is a new top-level package. Highlights: #184 #185 #186 #187 #188 #189 #190 #191 #192 #197 #198 #201 #202 #203 #204 #205 #206 #207 #209 #210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify-browseronmain.pnpm verify:browser:docker:updateso rendering matches the CI Playwright container exactly.Affected baselines (8)
harness-visual.browser{,.mobile,.desktop.dark,.mobile.dark}.png— full harness shots (toolbar visible)harness-visual.browser.slides-toolbar{,.mobile,.desktop.dark,.mobile.dark}.png— focused toolbar shotsTest plan
pnpm verify:browser:docker:updateproduces exactly these 8 file diffs (rest are byte-identical to HEAD).pnpm verify:fastgreen.verify-browserjob green on this branch.🤖 Generated with Claude Code