packages/slides/src/view/canvas/shapes/flowchart/or.ts (1)

14-21: 💤 Low value

Consider avoiding the duplicate endpoint in the ellipse approximation.

The loop iterates from i = 0 to i = segments (inclusive), which creates points at both angle 0 and angle 2π—the same position. The subsequent closePath() already handles the connection back to the start, making the duplicate point unnecessary.

♻️ Proposed refactor

- for (let i = 0; i <= segments; i++) {
+ for (let i = 0; i < segments; i++) {
    const angle = (i / segments) * Math.PI * 2;

This aligns with typical polygon approximation patterns and eliminates the redundant lineTo operation.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/slides/src/view/canvas/shapes/flowchart/or.ts` around lines 14 - 21,
The loop that approximates the ellipse currently iterates i = 0 to i <= segments
causing duplicate points at angle 0 and 2π; change the loop to iterate only up
to i < segments (or otherwise avoid the final angle duplicate) so the polygon
does not add a redundant lineTo before calling path.closePath(); update the loop
condition in the function that builds the ellipse (the for loop using variables
segments, angle, cx, cy, rx, ry and calling path.moveTo/path.lineTo) and keep
the existing path.closePath() as the sole connector back to the start.

packages/slides/src/view/canvas/shapes/builder.ts (1)

57-74: ⚡ Quick win

Validate points contract in regularPolygonPath.

The function documents points >= 3 but currently accepts invalid values silently. Add an explicit guard with a clear error.

♻️ Proposed fix

 export function regularPolygonPath(
   cx: number,
   cy: number,
   rx: number,
   ry: number,
   points: number,
   rotation: number = -Math.PI / 2,
 ): { x: number; y: number }[] {
+  if (!Number.isInteger(points) || points < 3) {
+    throw new RangeError(
+      'regularPolygonPath: `points` must be an integer greater than or equal to 3',
+    );
+  }
   const verts: { x: number; y: number }[] = [];
   for (let i = 0; i < points; i++) {
     const angle = rotation + (i / points) * Math.PI * 2;
     verts.push({
       x: cx + rx * Math.cos(angle),
       y: cy + ry * Math.sin(angle),
     });
   }
   return verts;
 }

As per coding guidelines, "Use meaningful error messages that help with debugging".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/slides/src/view/canvas/shapes/builder.ts` around lines 57 - 74, Add
an explicit validation at the start of regularPolygonPath to enforce points >=
3: check the points parameter (in the regularPolygonPath function) and if it's
less than 3 or not an integer, throw a clear Error with a meaningful message
like "regularPolygonPath: 'points' must be an integer >= 3, got: <value>" so
invalid inputs fail fast and aid debugging.

packages/slides/src/view/canvas/shapes/flowchart/punched-tape.ts (1)

20-21: ⚡ Quick win

Consider removing redundant lineTo before closePath.

Line 20's lineTo(0, topY) appears redundant because closePath() on line 21 automatically draws a straight line back to the starting point. The path already started at (0, topY) on line 16, so closePath() will close it correctly without the explicit lineTo.

♻️ Suggested simplification

   appendSineWave(path, w, 0, botY, -amp);
-  path.lineTo(0, topY);
   path.closePath();

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/slides/src/view/canvas/shapes/flowchart/punched-tape.ts` around
lines 20 - 21, Remove the redundant drawing call: the explicit path.lineTo(0,
topY) before path.closePath() is unnecessary because the path was started at (0,
topY) and closePath() will draw back to that start point; delete the
path.lineTo(0, topY) invocation (the surrounding code that sets up the path and
the subsequent path.closePath() should remain unchanged) and run the shape
rendering test to confirm no visual change.

packages/slides/src/view/canvas/shapes/flowchart/document.ts (1)

26-27: ⚡ Quick win

Consider removing redundant lineTo before closePath.

Line 26's lineTo(x, y) is redundant because the path already started at (x, y) on line 22, and closePath() on line 27 will automatically draw a straight line back to the starting point.

♻️ Suggested simplification

   appendSineWave(path, x + w, x, baseY, amp);
-  path.lineTo(x, y);
   path.closePath();

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/slides/src/view/canvas/shapes/flowchart/document.ts` around lines 26
- 27, Remove the redundant final segment: in the drawing routine in document.ts,
eliminate the extraneous path.lineTo(x, y) call just before path.closePath();
since the subpath already begins at (x, y) (created earlier in the same
function) and path.closePath() will implicitly draw the closing straight line,
remove the duplicate path.lineTo(x, y) to simplify the code and avoid an
unnecessary duplicate command.

docs/tasks/active/20260509-slides-shapes-p2-todo.md (1)

26-32: 💤 Low value

Minor: Add language identifier to fenced code block.

The fenced code block at line 26 should specify a language for better accessibility and rendering consistency.

📝 Suggested fix

-```
+```text
 docs/design/slides/slides-shapes-p2.md          (new — P2 spec)
 docs/design/slides/slides-shapes-p1.md          (modified — roadmap row)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/tasks/active/20260509-slides-shapes-p2-todo.md` around lines 26 - 32,
Add a language identifier to the fenced code block that lists the changed files
(the block that begins with ``` and contains the lines starting
"docs/design/slides/slides-shapes-p2.md          (new — P2 spec)" and the
subsequent file lines); update the opening fence to include a language such as
"text" (e.g., change the opening ``` to ```text) so the block is properly
labeled for rendering and accessibility.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes