Skip to content

Add CONTRIBUTING.md and surface Slides in README#204

Merged
hackerwins merged 1 commit into
mainfrom
add-contributing-md
May 10, 2026
Merged

Add CONTRIBUTING.md and surface Slides in README#204
hackerwins merged 1 commit into
mainfrom
add-contributing-md

Conversation

@hackerwins

@hackerwins hackerwins commented May 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • New top-level CONTRIBUTING.md covering the agentic workflow already used in the repo: design docs in docs/design/, task plans in docs/tasks/active/, the three verify lanes, commit format, PR + review process, AI agent-assisted contributions, and package-specific gotchas (ANTLR, Store/DocStore, integration tests, chunk budgets).
  • README's ## Contributing trimmed to a one-line pointer; Documentation index now lists CONTRIBUTING.md.
  • README updated to surface Slides: tagline now mentions all three editors, a ### Slides block under Features, a Slides engine row in Tech Stack, and packages/slides/ in Project Structure (also fixed packages/cli/ to link its README and updated the workspace-deps line).
  • Inspired loosely by warp's CONTRIBUTING.md but rewritten around our own conventions: no separate spec-PR flow, no per-PR CHANGELOG entry (release notes auto-generated), and a CLA marked as planned but not required today.

Why

The README's Contributing section was a stub and the agentic workflow was only documented in CLAUDE.md / AGENTS.md — fine for AI agents, but a poor entry point for human contributors. CONTRIBUTING.md is the conventional landing page that GitHub also surfaces in the issue/PR sidebar.

Slides has shipped enough features to warrant top-level visibility in the README; previously a reader could miss that the package existed.

Linked Issues

None.

Verification

CI automatically posts a verification summary comment on this PR with
per-lane results for both verify:self and verify:integration.

  • verify:self — CI comment shows ✅
  • verify:integration — CI comment shows ✅ (or explicit skip reason below)

Skip reason (if applicable):

Local: pnpm verify:fast green (47 test files / 764 tests). Docs-only change, no code paths touched.

Risk Assessment

  • User-facing risk: none — markdown docs only.
  • Data/security risk: none.
  • Rollback plan: revert the single commit.

Notes for Reviewers

  • Tracking task: docs/tasks/active/20260510-contributing-md-todo.md.
  • Decisions baked in (per owner): keep current style of putting design + code in one PR (no separate spec PR), keep auto-generated release notes (no per-PR CHANGELOG), CLA noted as planned but not required.
  • ## Status block in README still says "spreadsheet and document editing" — left as-is for now since Slides is still v1; happy to widen the wording in a follow-up if preferred.
  • Follow-up work: none required.

Summary by CodeRabbit

  • Documentation
    • Added comprehensive contribution guidelines with steps for bug fixes, features, and documentation contributions
    • Updated README describing Wafflebase as a web-based collaborative office suite
    • Added Slides feature documentation covering canvas editing, themes, and import/export capabilities
    • Expanded Tech Stack documentation with Slides engine and backend technology details
    • Enhanced contributor onboarding resources with workflow steps and verification expectations

Review Change Stack

Move the contributor workflow out of the stub Contributing section
into a top-level CONTRIBUTING.md so external contributors and agents
can find it without first reading CLAUDE.md. Covers the design-doc +
task-plan workflow, verification lanes, commit format, PR and review
process, AI agent-assisted contributions, and package-specific
gotchas.

Also surface Slides in the README. The package was missing from the
Features list, the Tech Stack table, and the Project Structure list,
so a casual reader could not tell Slides existed. Update the tagline
to mention sheets, docs, and slides together.
@coderabbitai

coderabbitai Bot commented May 9, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This pull request introduces a comprehensive contribution guide for Wafflebase (CONTRIBUTING.md) with workflows for bug fixes, features, and documentation changes; updates the README to reference the guide and reflect the addition of Slides to the product scope; and records this work in the active task index.

Changes

Add Contribution Guidelines

Layer / File(s) Summary
Contribution Guidelines Overview
CONTRIBUTING.md
Header introduces the document scope. TL;DR summarizes paths for bug fixes, non-trivial features (design doc + task + PR), and docs/refactors. "Before you start" checklist covers issue/design doc searches, early alignment, and CLA expectations.
Contribution Paths and Operational Procedures
CONTRIBUTING.md
Bug fix path takes direct PR; non-trivial features require design docs and task plans in same PR; docs/refactors require motivation statement. Verification gates specify which pnpm verify:* commands to run per change scope. Commit message format requires subject length/casing and body wrapping. PR workflow covers branching, self-verify, self-review, rebasing, template requirements, and green-gate checklist. Code review section emphasizes comment-thread replies, technical norms, and rebasing if main moves during review.
Special Considerations and Policies
CONTRIBUTING.md
AI agent–assisted contributions must include human sign-off and follow standard workflow; avoid secret/lockfile/formatter drift. Package-specific gotchas include ANTLR file handling, Store/DocStore boundary enforcement, integration/e2e test setup, and frontend chunk budget enforcement. Security issues are reported privately via email. Licensing terms and CLA notes are restated. Further reading links key project docs.
Project Scope and Structure Updates
README.md
Product description is revised to emphasize collaborative office-suite capabilities (spreadsheets, documents, presentations). Slides feature section details free-position canvas, themes/layouts, two-pane editor, and PPTX import / PDF export. Tech Stack table adds Slides-engine row. Project Structure adds packages/slides entry and lists @wafflebase/sheets, @wafflebase/docs, @wafflebase/slides as frontend workspace dependencies.
Documentation References and Links
README.md
Contributing section replaces prior text with pointer to CONTRIBUTING.md. Documentation section adds CONTRIBUTING.md link alongside existing design docs reference.
Task Tracking and Index Updates
docs/tasks/README.md, docs/tasks/active/20260510-contributing-md-todo.md
Active task index adds "add CONTRIBUTING.md (2026-05-10)" entry with todo file link. Latest active task marker updated. Task todo file specifies decisions (no CLA, GitHub auto-generated changelogs), file map, and step-by-step plan with pnpm verify:fast verification.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • wafflebase/wafflebase#89: Adds pre-commit hook and policy to restrict docs/ structure; this PR's task tracking in docs/ is affected by that restriction.
  • wafflebase/wafflebase#166: Makes documentation-structure and README/docs/tasks linking changes; both PRs surface and reorganize project documentation references.

Poem

A fresh guide for those who would create,
with workflows clear and rules ornate,
contributed now to the CONTRIBUTING tome—
a welcome map that guides folks home. 🐰✨
All changes bright in task-tracked light!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the two main changes: adding CONTRIBUTING.md and surfacing Slides in README, both of which are clearly present in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-contributing-md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

Verification: verify:self

Result: ✅ PASS in 163.2s

Lane Status Duration
sheets:build ✅ pass 12.7s
docs:build ✅ pass 11.6s
slides:build ✅ pass 8.8s
verify:fast ✅ pass 89.3s
frontend:build ✅ pass 16.1s
verify:frontend:chunks ✅ pass 0.3s
backend:build ✅ pass 4.5s
cli:build ✅ pass 1.9s
verify:entropy ✅ pass 18.0s

Verification: verify:integration

Result: ✅ PASS

@codecov

codecov Bot commented May 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hackerwins
hackerwins merged commit 79476c2 into main May 10, 2026
4 checks passed
@hackerwins
hackerwins deleted the add-contributing-md branch May 10, 2026 00:29
hackerwins added a commit that referenced this pull request May 10, 2026
Each package already has its own README, but there was no top-level
entry point inside `packages/` that summarised what lives where.
Splits the listing into engines (sheets, docs, slides) and apps and
services (frontend, backend, cli, documentation) so a new contributor
can orient before drilling into a single package.

Four active tasks have shipped on main (PR #189 undo-destroys-initial-block,
#202+#205 slides-shapes-p1, #206 slides-thumb-responsive, #204
contributing-md) but their todo files were still sitting in
`docs/tasks/active/` because some checkboxes were never ticked. Mark
the remaining items done and run `pnpm tasks:archive` to move the five
files into `archive/2026/05/`.

While there, eight April task docs were still loose at the archive
root (predating the by-month layout). Move them into `archive/2026/04/`
so the directory is uniformly organised and the index counts stay
accurate.

Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
@hackerwins hackerwins mentioned this pull request May 11, 2026
6 tasks
hackerwins added a commit that referenced this pull request May 11, 2026
Adds @wafflebase/slides as a third surface alongside Sheets and Docs,
plus 53-shape library (Phase 1+2), adjustment handles for 9 pilot
shapes (P3-A.1), live snap guides, align/distribute toolbar, themed
authoring, and layout-change UI. Also ships Sheets cell comments
(Phase B), docs peer-avatar caret jump, yorkie-js-sdk 0.7.8 upgrade,
and CLI/REST API improvements (docs export imageFetcher, expired
session refresh, REST docs split). Minor bump because slides is a
new top-level package.

Highlights: #184 #185 #186 #187 #188 #189 #190 #191 #192 #197 #198
#201 #202 #203 #204 #205 #206 #207 #209 #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant