packages/cli/test/config.test.ts (1)

60-112: ⚡ Quick win

Add one negative session-token edge test to lock guard behavior.

You already cover valid and expired access-token paths. Please also assert that when either token is missing, resolveConfig({}) does not select authMode: 'jwt' (protects the new session.accessToken && session.refreshToken contract at Line 112).

🧪 Suggested test addition

   describe('session-backed JWT auth', () => {
@@
     it('keeps JWT auth and workspace when access token is expired but refresh token exists', () => {
       writeSessionFile({ expiresAt: new Date(Date.now() - 60_000).toISOString() });
       const config = resolveConfig({});
       expect(config.authMode).toBe('jwt');
       expect(config.workspace).toBe('ws-from-session');
       expect(config.accessToken).toBe('access-token');
       expect(config.refreshToken).toBe('refresh-token');
     });
+
+    it('does not use JWT auth when refresh token is missing', () => {
+      writeSessionFile({ refreshToken: '' });
+      const config = resolveConfig({});
+      expect(config.authMode).not.toBe('jwt');
+    });
   });

As per coding guidelines, "**/*.{test,spec}.{js,ts,jsx,tsx}: Write tests for critical business logic and edge cases".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/cli/test/config.test.ts` around lines 60 - 112, Add a negative test
in the 'session-backed JWT auth' describe block that uses writeSessionFile to
create a session missing either accessToken or refreshToken (e.g., omit
accessToken and/or refreshToken in overrides), calls resolveConfig({}), and
asserts that config.authMode is not 'jwt' and that
workspace/accessToken/refreshToken are not taken from the session; this protects
the new session.accessToken && session.refreshToken contract checked in
resolveConfig.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes