packages/sheets/test/sheet/formatting.test.ts (1)

383-505: Optional: add a count > 1 insertion case.

A multi-insert variant would further lock in the index + count seam lookup and inserted-span loop behavior.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/sheets/test/sheet/formatting.test.ts` around lines 383 - 505, Add a
test that inserts more than one row/column inside a bordered range to exercise
the index+count seam logic: reuse Sheet, MemStore, selectStart/selectEnd,
setRangeBorders('outer') then call insertRows(startIndex, count>1) and
insertColumns(startIndex, count>1) and assert that (1) the newly inserted span
inherits the correct outer-edge borders across all inserted cells (e.g.,
left-edge for all inserted rows in column X or top-edge for all inserted columns
in row Y), (2) no interior top/bottom or left/right borders are spuriously set
on those inserted cells, and (3) the original bordered cells after the insertion
have been shifted by count with their original borders intact using getStyle to
verify both edge cases; place tests near the existing insertRows/insertColumns
cases to cover multi-insert behavior.

packages/sheets/src/model/worksheet/sheet.ts (1)

1162-1168: Prefer bounded seam ranges over Number.MAX_SAFE_INTEGER.

Clamping to sheet dimensions keeps the query window explicit and avoids relying on store-specific handling of very large bounds.

♻️ Suggested refactor

-    const upper = Number.MAX_SAFE_INTEGER;
-    const beforeRange: Range = axis === 'row'
-      ? [{ r: index - 1, c: 1 }, { r: index - 1, c: upper }]
-      : [{ r: 1, c: index - 1 }, { r: upper, c: index - 1 }];
-    const afterRange: Range = axis === 'row'
-      ? [{ r: index + count, c: 1 }, { r: index + count, c: upper }]
-      : [{ r: 1, c: index + count }, { r: upper, c: index + count }];
+    const maxRow = this.dimension.rows;
+    const maxCol = this.dimension.columns;
+    const beforeRange: Range = axis === 'row'
+      ? [{ r: index - 1, c: 1 }, { r: index - 1, c: maxCol }]
+      : [{ r: 1, c: index - 1 }, { r: maxRow, c: index - 1 }];
+    const afterRange: Range = axis === 'row'
+      ? [{ r: index + count, c: 1 }, { r: index + count, c: maxCol }]
+      : [{ r: 1, c: index + count }, { r: maxRow, c: index + count }];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/sheets/src/model/worksheet/sheet.ts` around lines 1162 - 1168, The
ranges beforeRange and afterRange use Number.MAX_SAFE_INTEGER as an unbounded
upper coordinate; replace that with the worksheet's actual max row/column bounds
by clamping using the sheet dimensions (e.g. this.getRowCount()/this.rowCount
and this.getColCount()/this.colCount or equivalent accessors on the worksheet)
so upper is set to the appropriate max for the current axis; update the creation
of beforeRange and afterRange (which use axis, index, count and type Range) to
compute upperRow = min(this.maxRows, Number.MAX_SAFE_INTEGER) and upperCol =
min(this.maxCols, Number.MAX_SAFE_INTEGER) (or simply use the worksheet maxs)
and use those bounded values instead of Number.MAX_SAFE_INTEGER.