Skip to content

Import nested tables from .docx as actual table blocks#129

Merged
hackerwins merged 1 commit into
mainfrom
fix/docx-nested-table-import
Apr 14, 2026
Merged

Import nested tables from .docx as actual table blocks#129
hackerwins merged 1 commit into
mainfrom
fix/docx-nested-table-import

Conversation

@hackerwins

@hackerwins hackerwins commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the isNested flattening logic in DocxImporter.convertTable() that converted nested <w:tbl> elements to plain text paragraphs
  • Nested tables are now imported as real table blocks, preserving full document structure at any depth
  • Remove unused extractText() helper that was only used for flattening
  • Update tests to verify nested table structure is preserved

Test plan

  • pnpm verify:fast passes
  • Import ~/Downloads/form.docx and verify nested tables render correctly
  • Export document with nested tables and re-import to verify round-trip

🤖 Generated with Claude Code

@hackerwins @claude
Import nested tables as actual table blocks from .docx
748efe0 
The importer was flattening nested tables to plain text paragraphs
since nested table support didn't exist yet. Now that nested tables
are fully supported (#128), import them as real table blocks to
preserve document structure.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@hackerwins has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 28 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 21 minutes and 28 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fa09e7e2-27e0-41a6-8346-edd882f6d968

📥 Commits

Reviewing files that changed from the base of the PR and between 32aa3be and 748efe0.

📒 Files selected for processing (2)
  • packages/docs/src/import/docx-importer.ts
  • packages/docs/test/import/docx-importer.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docx-nested-table-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Verification: verify:self

Result: ✅ PASS in 113.5s

Lane Status Duration
sheets:build ✅ pass 13.1s
docs:build ✅ pass 7.6s
verify:fast ✅ pass 57.2s
frontend:build ✅ pass 14.7s
verify:frontend:chunks ✅ pass 0.3s
backend:build ✅ pass 4.6s
cli:build ✅ pass 1.7s
verify:entropy ✅ pass 14.2s

Verification: verify:integration

Result: ✅ PASS

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hackerwins
hackerwins merged commit 9bdd2aa into main Apr 14, 2026
4 checks passed
@hackerwins
hackerwins deleted the fix/docx-nested-table-import branch April 14, 2026 05:33
@hackerwins hackerwins mentioned this pull request Apr 14, 2026
Merged
hackerwins added a commit that referenced this pull request Apr 19, 2026
@hackerwins
Archive 7 completed tasks
af3cab1 
- random-axis-id (#127)
- axis-id-selection (#130)
- docs-image-editing Phase 1 (#121, #123)
- nested-tables (#128, #129)
- docs-mobile-toolbar (#132)
- release-v0.3.3 (#131)
- docs-image-editing lessons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hackerwins