packages/docs/src/view/doc-canvas.ts (1)

173-184: Consider extracting hardcoded styling values to Theme constants.

The font ('9px Arial'), colors ('#aaa', '#ccc'), and dash pattern ([4, 4]) are hardcoded. For consistency with other rendering code that uses Theme.* constants, these could be centralized.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/docs/src/view/doc-canvas.ts` around lines 173 - 184, Extract the
hardcoded styling in the Page break render block into Theme constants and use
them instead of literals: replace this.ctx.font = '9px Arial' with
Theme.pageBreakFont, this.ctx.fillStyle = Theme.pageBreakTextColor,
this.ctx.strokeStyle = Theme.pageBreakLineColor and this.ctx.setLineDash([4,4])
with Theme.pageBreakDash (an array); also replace the hardcoded padding added to
labelWidth (+16) with Theme.pageBreakLabelPadding and ensure the label string
'Page break' can be referenced as Theme.pageBreakLabel so all values (font, text
color, line color, dash pattern, label padding, label text) are centralized for
consistency in the DocCanvas page break rendering code.

docs/design/docs/docs-pagination.md (1)

332-396: Comprehensive design documentation for Manual Page Break.

The new section thoroughly documents all aspects of the page-break feature:

• Data model following the horizontal-rule pattern
• Pagination engine behavior with clear algorithm description
• Layout and rendering specifications
• Input handling including keyboard shortcuts
• Document model operations
• Yorkie serialization approach

One minor improvement: the pseudocode block at lines 362-365 could specify a language for consistency.

,

Optional: Add language to code block

-```
+```typescript
 const PAGE_BREAK_HEIGHT = 20;
 lines = [{ runs: [], y: 0, height: PAGE_BREAK_HEIGHT, width: availableWidth }];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/design/docs/docs-pagination.md` around lines 332 - 396, The code fence
for the pseudocode in the computeLayout section is missing a language specifier;
update the triple-backtick block that defines PAGE_BREAK_HEIGHT and lines (the
snippet containing "const PAGE_BREAK_HEIGHT = 20;" and "lines = [{ runs: [], y:
0, height: PAGE_BREAK_HEIGHT, width: availableWidth }];") to use ```typescript
so syntax highlighting and consistency match the rest of the docs.

docs/tasks/active/20260408-page-break-todo.md (1)

11-13: Minor: Heading level jumps from h1 to h3.

The document structure skips h2 and goes directly to h3 for "Task 1". Consider using h2 (##) for task headers for proper document hierarchy, or add a "## Tasks" section header before the task list.

Suggested fix

 ---
 
+## Tasks
+
 ### Task 1: Add `page-break` to data model and createBlock

Or change all ### task headers to ##.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/tasks/active/20260408-page-break-todo.md` around lines 11 - 13, The
document jumps from h1 to h3 for the task header "Task 1: Add `page-break` to
data model and createBlock"; update the heading hierarchy by either changing the
task header "### Task 1: Add `page-break` to data model and createBlock" to an
h2 (replace ### with ##) or insert a parent "## Tasks" section above the task
list so all task entries remain as h3—pick one approach and apply it
consistently for other task headers.