Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting preferred path to Chrome executable #375

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented Apr 18, 2023

Description

Specifying the location of the Chrome executable is supported, it is preferred to set the path using the CHROME_BIN environment variable.

Closes #369

Checklist

@waybackarchiver waybackarchiver added enhancement New feature or request go Pull requests that update Go code labels Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (36eb9cc) 47.13% compared to head (14e2415) 47.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   47.13%   47.11%   -0.02%     
==========================================
  Files          58       58              
  Lines        5138     5138              
==========================================
- Hits         2422     2421       -1     
- Misses       2453     2454       +1     
  Partials      263      263              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver merged commit 99c2021 into main Apr 18, 2023
@waybackarchiver waybackarchiver deleted the chrome-bin branch April 18, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap not finding google-chrome executable.
1 participant