Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate torrc configuration #332

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Deprecate torrc configuration #332

merged 3 commits into from
Mar 10, 2023

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented Mar 7, 2023 •
edited
Loading

Description

Issue Ticket Number

Fixes #(issue_number)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (08cb62c) 45.50% compared to head (047700f) 45.62%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   45.50%   45.62%   +0.11%     
==========================================
  Files          56       56              
  Lines        5193     5164      -29     
==========================================
- Hits         2363     2356       -7     
+ Misses       2571     2548      -23     
- Partials      259      260       +1
Impacted Files Coverage Δ
config/options.go 93.69% <ø> (-0.06%) ⬇️
config/parser.go 91.77% <ø> (-0.08%) ⬇️
service/httpd/tor.go 0.00% <0.00%> (ø)
publish/nostr/nostr.go 40.22% <0.00%> (-2.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver force-pushed the main branch 4 times, most recently from 7344fb6 to 54a6fb3 Compare March 7, 2023 12:11
@waybackarchiver waybackarchiver changed the title Deprecate torrc Deprecate torrc configuration Mar 7, 2023
@waybackarchiver waybackarchiver marked this pull request as ready for review March 7, 2023 12:16
@waybackarchiver waybackarchiver added the go Pull requests that update Go code label Mar 7, 2023
@waybackarchiver waybackarchiver merged commit 8488973 into main Mar 10, 2023
@waybackarchiver waybackarchiver deleted the deprecate-torrc branch March 10, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@waybackarchiver