Skip to content

Improve log message#213

Merged
w3stling merged 3 commits intomasterfrom
improve-logging
Apr 15, 2025
Merged

Improve log message#213
w3stling merged 3 commits intomasterfrom
improve-logging

Conversation

@w3stling
Copy link
Owner

@w3stling w3stling commented Apr 14, 2025 •
edited
Loading

This PR fixes issue #212

Improves log messages by including the feed URL or file path when exceptions are caught.

Example log message:

WARNING: Failed to parse XML from feed https://capitallinkshipping.com/login/?redirect_to=https%3A%2F%2Fcapitallinkshipping.com%2Ffeed%2F
javax.xml.stream.XMLStreamException: ParseError at [row,col]:[1,3]
Message: The markup in the document preceding the root element must be well-formed.
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLStreamReaderImpl.next(XMLStreamReaderImpl.java:652)
	at com.apptasticsoftware.rssreader.AbstractRssReader$RssItemIterator.next(AbstractRssReader.java:698)
	at com.apptasticsoftware.rssreader.AbstractRssReader$RssItemIterator.peekNext(AbstractRssReader.java:674)
	at com.apptasticsoftware.rssreader.AbstractRssReader$RssItemIterator.hasNext(AbstractRssReader.java:683)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
...

@w3stling w3stling added the bug Something isn't working label Apr 14, 2025
@github-actions
Copy link

github-actions bot commented Apr 14, 2025 •
edited
Loading

Test Results

 11 files   11 suites   37s ⏱️
302 tests 301 ✅ 1 💤 0 ❌
310 runs  309 ✅ 1 💤 0 ❌

Results for commit 04ce120.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@w3stling w3stling merged commit b71f1dd into master Apr 15, 2025
6 checks passed
@w3stling w3stling deleted the improve-logging branch April 15, 2025 05:06
@w3stling w3stling mentioned this pull request Apr 15, 2025
Closed
@w3stling w3stling added chore and removed bug Something isn't working labels Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@w3stling