Sync from origin #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11356) * fix(sap): SAP HANA Cloud data types * fix(sap): fall back to regular index when fulltext is not supported * fix: remove dead code
* Add ExpoDriverFactory to create ExpoLegacyDriver * Add driver for new Expo SQLite API --------- Co-authored-by: Ruben Grimm <[email protected]> Co-authored-by: Lucian Mocanu <[email protected]>
…11082) * fix: resolve issues in insert query orUpdate method with postgres driver This fix make use of table name alias in WHERE clause of onUpdate method with postgres driver to avoid throwing error Closes: #11077 * test: update insert on conflict test --------- Co-authored-by: Lucian Mocanu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes changes from origin, updating various tests and driver implementations to improve compatibility and functionality. Key updates include refactored version checks in PostgreSQL and SAP drivers, revised query builder logic, and enhanced support for Expo and SAP HANA Cloud.
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/github-issues/9318/issue-9318.ts | Reordered imports and updated driver version comparison using DriverUtils |
| test/functional/query-builder/insert-on-conflict/query-builder-insert-on-conflict.ts | Switched test variable names from connections to dataSources and updated test descriptions |
| test/functional/database-schema/column-types/sap/column-types-sap.ts | Adjusted column type assertions to reflect SAP HANA Cloud behavior |
| test/functional/database-schema/column-length/sap/column-length-sap.ts | Corrected import order and updated entity import for SAP column length tests |
| test/functional/cube/postgres/cube-postgres.ts | Updated Postgres version check using DriverUtils |
| src/query-builder/InsertQueryBuilder.ts | Revised SQL query construction logic in the insert query builder |
| src/driver/sap/SapQueryRunner.ts | Removed unnecessary charset/collation handling and adjusted fulltext index logic |
| src/driver/sap/SapDriver.ts | Normalized deprecated/removed SAP data types and adjusted float conversion logic |
| src/driver/postgres/PostgresQueryRunner.ts | Updated version query comments and logic for improved compatibility |
| src/driver/expo/legacy/ExpoLegacyQueryRunner.ts | Added comprehensive transaction and query execution handling for Expo legacy driver |
| src/driver/expo/legacy/ExpoLegacyDriver.ts | Provided proper disconnect and query runner creation for Expo legacy driver |
| src/driver/expo/ExpoQueryRunner.ts | Reworked query execution to use async/await with prepared statements |
| src/driver/expo/ExpoDriverFactory.ts | Introduced a factory to choose between Expo and Expo legacy drivers based on configuration |
| src/driver/expo/ExpoDriver.ts | Updated connection creation and query runner instantiation for Expo driver |
| src/driver/DriverFactory.ts | Revised Expo driver instantiation to use the new factory |
| docs/entities.md | Updated documentation to include SAP column types and behavior notes |
| CHANGELOG.md | Documented SAP changes and other bug fixes/features introduced in this release |
| .github/workflows/publish-package.yml | Added workflow to publish package to npm on release events |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/query-builder/InsertQueryBuilder.ts:581
- The removal of an appended whitespace (previously added via 'query += " "') could lead to SQL syntax errors if subsequent query parts are concatenated without proper separation. Please verify that the generated SQL query contains all necessary spaces between clauses.
query += updatePart.join(", ")
Pull Request Test Coverage Report for Build 14239482233Details
💛 - Coveralls |
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.1 to 2.1.2. - [Commits](mafintosh/tar-fs@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: tar-fs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add new foreign key decorator, and entity schemas options This new feature adds the ability to create foreign key constraints without entity relations, using `@ForeignKey()` decorator or entity schema options. Closes: #4569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000