Sync with origin #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* build: setup SAP HANA tests * test: fix/skip failing SAP HANA tests * fix(sap): rename schema
* fix: export * from `subscriber/event/QueryEvent` Otherwise it's impossible to create a listener/subscriper that is using the Before/After query event types * docs: clarify that QueryEvent execution time result is in ms
resolve issue with bulk insert of NULL values for non VARCHAR2 types in Oracle.
* fix: sql escape issues identified by CodeQL * fix: random generation in sample code
There was a problem hiding this comment.
Pull Request Overview
This pull request synchronizes driver implementations, configuration files, and documentation with upstream changes. Key updates include:
- Renaming and modifying methods in SAP and Cockroach database drivers (e.g. getVersion → getDatabaseAndVersion).
- Replacing RegExp-based string replacements with replaceAll for enum values and query strings.
- Updating docker-compose, developer documentation, and GitHub workflows to reflect current configuration and testing standards.
Reviewed Changes
Copilot reviewed 53 out of 58 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/driver/sap/SapQueryRunner.ts | Renamed the method to return both database and version info; adjusted query. |
| src/driver/sap/SapDriver.ts | Updated driver to use the new getDatabaseAndVersion method. |
| src/driver/postgres/PostgresQueryRunner.ts | Replaced RegExp replace with replaceAll for cleaner code. |
| src/driver/postgres/PostgresDriver.ts | Switched from substr to slice for string trimming and simplified regex. |
| src/driver/mongodb/MongoDriver.ts | Refactored option extraction and driver info assignment in connection options. |
| src/driver/mongodb/MongoConnectionOptions.ts | Updated and rearranged MongoDB connection options and documentation. |
| src/driver/cockroachdb/CockroachQueryRunner.ts | Applied similar replaceAll improvements to enum handling. |
| src/driver/cockroachdb/CockroachDriver.ts | Adjusted string slice usage for enum conversion consistency. |
| src/commands/MigrationGenerateCommand.ts | Improved query string escaping using replaceAll. |
| sample/sample9-entity-listeners/entity/Post.ts | Updated entity listener code to utilize crypto.randomInt for UID generation. |
| docker-compose.yml | Revised SAP HANA configuration and healthchecks. |
| DEVELOPER.md | Updated instructions to reference the new sample file for ormconfig. |
| .github/workflows/*.yml | Renamed and restructured workflow configuration for better clarity. |
Files not reviewed (5)
- .github/workflows/database-compose-tests.yml: Language not supported
- .github/workflows/test/oracle.docker-compose.yml: Language not supported
- .github/workflows/test/oracle.ormconfig.json: Language not supported
- ormconfig.sample.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/driver/mongodb/MongoConnectionOptions.ts:121
- Changing the type of 'keepAlive' from a number to a boolean may affect consumers expecting a numeric timeout; please confirm that this breaking change is intentional and update related documentation if necessary.
readonly keepAlive?: boolean
Pull Request Test Coverage Report for Build 14197127864Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000