Add a capability for returning the default user agent header value#652
Add a capability for returning the default user agent header value#652
Conversation
jrandolf-google
left a comment
jrandolf-google
left a comment
There was a problem hiding this comment.
The CDDL also needs to be updated.
whimboo
left a comment
whimboo
left a comment
There was a problem hiding this comment.
We discussed this yesterday and actually wonder if it wouldn't even be better to add the userAgent capability to the WebDriver classic specification. That way we wouldn't have to make this capability BiDi specific.
If you agree this PR would have to be changed to only update the CDDL definition.
|
@whimboo is there a requirement for that from the classic users? |
|
So, in detail, the proposal as specified here is that you'd get an additional capability if the implementation supports BiDi irrespective of whether BiDi is requested or enabled (I think that's different to what I said in the previous discussion). I still think that doesn't make any sense, and we should just add the capability directly to classic. |
|
@jgraham I see, that makes sense. I have opened a PR here w3c/webdriver#1790 |
OrKoN
force-pushed
the
orkon/user-agent-capability
branch
from
6f24609 to
f57ecd1
Compare
whimboo
left a comment
whimboo
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks.
) SHA: f00427b Reason: push, by OrKoN Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
4 participants
This PR would allow client to get the original default User-Agent header value. In Puppeteer, it would allow supporting the
Browser.userAgent()API.Closes #446
Preview | Diff