Conversation
Fixes #347.
whimboo
approved these changes
Jan 2, 2023
whimboo
left a comment
whimboo
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me. Thanks.
github-actions Bot
added a commit
that referenced
this pull request
Jan 2, 2023
SHA: a2f64a5 Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
You'll want to do the same for the other two fields. Claiming "id" and "status" globally doesn't seem good. |
Member
Author
|
I actually expected the build to fail so I could iterate some more on this, but I guess not. I'll send another PR. |
Member
Author
This was referenced Jan 26, 2023
whimboo
pushed a commit
to whimboo/webdriver-bidi
that referenced
this pull request
Feb 3, 2023
whimboo
pushed a commit
to whimboo/webdriver-bidi
that referenced
this pull request
Feb 3, 2023
Follow-up to w3c#348.
sadym-chromium
pushed a commit
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #347.
Preview | Diff