Allow ignoring position or dimensions in set window rect#1830
Merged
Conversation
Previously it was unclear if it was acceptable to return without error from set window rect if the implementation is unable to set some of the properties. This updates the spec so that: * It's unambiguously OK to run the command even if you don't support some aspects of the functionality on the current platform / configuration (you are expected to continue to return an error if you don't support any aspect of the functionality). * It's clear that both position and dimension properties are best effort, and even if you are able to adjust them there's no guarantee that you get the exact requested values. * It's clear what to do if you get just an x coordinate but not y, or just width but not height, or vice-versa. Previously this was undefined.
whimboo
approved these changes
Jul 16, 2024
Contributor
whimboo
left a comment
whimboo
left a comment
There was a problem hiding this comment.
Thanks James! The changes look good to me.
Contributor
OrKoN
approved these changes
Jul 16, 2024
Member
Author
|
After merging this I noticed we have some uniformly passing tests that assume that input like |
yezhizhen
added a commit
to yezhizhen/wpt
that referenced
this pull request
Jun 26, 2025
The spec was changed in w3c/webdriver#1830 to allow partial parameter and change with best-effort. This makes some test assertion out-dated. This commit removes those out-dated test and move them to a new function `test_partial_input` to match the new expecation. Fixes: web-platform-tests#53409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was unclear if it was acceptable to return without error from set window rect if the implementation is unable to set some of the properties.
This updates the spec so that:
It's unambiguously OK to run the command even if you don't support some aspects of the functionality on the current platform / configuration (you are expected to continue to return an error if you don't support any aspect of the functionality).
It's clear that both position and dimension properties are best effort, and even if you are able to adjust them there's no guarantee that you get the exact requested values.
It's clear what to do if you get just an x coordinate but not y, or just width but not height, or vice-versa. Previously this was undefined.
Preview | Diff