Add a WebDriver Extension Capability#1353
Merged
jcjones merged 3 commits intow3c:masterfrom Jan 22, 2020
Merged
Conversation
equalsJeffH
reviewed
Dec 11, 2019
Contributor
equalsJeffH
left a comment
equalsJeffH
left a comment
There was a problem hiding this comment.
overall this looks good, modulo a few minor questions/comments -- thx @nsatragno !
fix nits Co-Authored-By: =JeffH <[email protected]>
equalsJeffH
approved these changes
Dec 13, 2019
Contributor
equalsJeffH
left a comment
equalsJeffH
left a comment
There was a problem hiding this comment.
LGTM, thx @nsatragno !
akshayku
approved these changes
Jan 22, 2020
jcjones
approved these changes
Jan 22, 2020
Contributor
jcjones
left a comment
jcjones
left a comment
There was a problem hiding this comment.
Looks fine to me, and simplifies WebDriver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a WebDriver capability that indicates support for the Virtual Authenticators automation API. This simplifies integration between browser automation frameworks and the automation API.
Fixes #1351
Preview | Diff