Skip to content

Do not check callerRealm for eval#540

Merged
antosart merged 1 commit intow3c:mainfrom
antosart:fix-eval
Feb 23, 2022
Merged

Do not check callerRealm for eval#540
antosart merged 1 commit intow3c:mainfrom
antosart:fix-eval

Conversation

@antosart
Copy link
Copy Markdown
Member

@antosart antosart commented Feb 21, 2022

According to WPTs web-platform-tests/wpt#32898, Firefox, Safari and Chrome only check policies of the calleeRealm for determining if eval is allowed. This change adapt the spec to adhere the vendors' implementation.

@antosart
Copy link
Copy Markdown
Member Author

antosart commented Feb 21, 2022

See #539 and #438.

@antosart antosart requested review from annevk and mikewest February 21, 2022 08:22
@antosart
Copy link
Copy Markdown
Member Author

antosart commented Feb 21, 2022

If preferred, I can also open PRs on html and ecmascript to remove the parameter callerRealm from everywhere.

annevk
annevk approved these changes Feb 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to clean up HTML and JS too. That would also allow for removal of the note.

@antosart
Copy link
Copy Markdown
Member Author

antosart commented Feb 21, 2022

I'll clean up HTML and JS then. Let's merge this one first.

@antosart antosart merged commit a284913 into w3c:main Feb 23, 2022
@antosart antosart deleted the fix-eval branch February 23, 2022 08:43
github-actions bot added a commit that referenced this pull request Feb 23, 2022
@antosart @github-actions
Do not check callerRealm for eval (#540)
b18e2b9 
SHA: a284913
Reason: push, by @antosart

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@antosart antosart mentioned this pull request Feb 23, 2022
Merged
antosart added a commit that referenced this pull request Apr 22, 2022
@antosart
Remove callerRealm param from EnsureCSPDoesNotBlockStringCompilation (#…
4430aa5 
…541)

This PR cleans up the EnsureCSPDoesNotBlockStringCompilation algorithm removing the callerRealm parameter, which is not used.

See also #540 and #438.
@antosart antosart mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk approved these changes

@mikewest mikewest Awaiting requested review from mikewest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antosart @annevk