Check transient activation after sharePromise#183
Merged
ewilligers merged 1 commit intow3c:masterfrom Sep 24, 2020
Merged
Conversation
WPT web-share/share-sharePromise-internal-slot.https.html has multiple navigator.share() calls within a single onclick handler. This is a good way to test the sharePromise internal slot, but it was not previously permitted by the spec, as the first call would consume activation and the later calls would fail with NotAllowedError instead of InvalidStateError.
marcoscaceres
approved these changes
Sep 24, 2020
Member
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
This matches what Gecko does too, so 👍
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 24, 2020
Spec: https://w3c.github.io/web-share/#share-method If a share() request is active when share() is called again, the new share request fails immediately. w3c/web-share#113 In content shell, the OS-integration for the share service is not present. Instead of crashing in tests, we report a not implemented error. WPT web-share/share-sharePromise-internal-slot.https.html now passes - it previously crashed. w3c/web-share#183 improves consistency between the test and the spec. Protocols other that http and https are no longer supported by share() or canShare(). w3c/web-share#174 canShare is being discussed in w3c/web-share#177 Bug: 1002337, 1002514, 1131755 Change-Id: I4ec9f6eb03373fd5c6db1881df906a8df36ca4ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WPT web-share/share-sharePromise-internal-slot.https.html
has multiple
navigator.share()calls within a singleonclickhandler. This is a good way to test the sharePromiseinternal slot, but it was not previously permitted by the spec,
as the first call would consume activation and the later calls
would fail with
NotAllowedErrorinstead ofInvalidStateError.For normative changes, the following tasks have been completed:
Implementation commitment: