Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe that type-scoped contexts are only in affect on the node objects in which they're used #195

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Describe that type-scoped contexts are only in affect on the node objects in which they're used #195

merged 2 commits into from
Jun 20, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jun 19, 2019 •
edited by pr-preview bot
Loading

Add changes for type-scoped contexts.

Fixes #174.

Preview | Diff

@gkellogg
Describe that type-scoped contexts are only in affect on the node obj…
c3c9592 
…ects in which they're used. Add changes for type-scoped contexts.

Fixes #174.
@gkellogg gkellogg requested review from dlongley and pchampin June 19, 2019 18:44
pchampin
pchampin approved these changes Jun 19, 2019
View reviewed changes
dlongley
dlongley approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I suggested a potential additional sentence that might help clarify things to address @pchampin's concern.

@gkellogg
Applied @dlongley's suggestion on noting that local contexts introduc…
08b3a1c 
…ed when a type-scoped context is in effect remain in effect in descendant node objects.
@gkellogg gkellogg merged commit 3fb9b47 into master Jun 20, 2019
@gkellogg gkellogg deleted the type-scoped-context-refinement branch June 20, 2019 20:34
@gkellogg gkellogg mentioned this pull request Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@pchampin pchampin pchampin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected @type scope behavior (term definitions persist throughout JSON tree)
3 participants
@gkellogg @dlongley @pchampin