Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of sentence addressing issues #90 and #93 about versions #780

Merged
merged 7 commits into from
Mar 26, 2019

Conversation

riccardoAlbertoni
Copy link
Contributor

Dear Alejandra and Jaro,
I have drafted a couple of sentences addressing issues #90 and #93 about versioning.

Since as far as I have understood you are working on the section related to versioning, I wonder if you want to include it in your proposal about versioning.

Thanks a lot,
Riccardo

@agbeltran agbeltran changed the title Draft of sentence addressing issues #90 and #93 about revisions Draft of sentence addressing issues #90 and #93 about versions Mar 12, 2019
@davebrowning davebrowning added this to the DCAT CR milestone Mar 14, 2019
1. corrected 'retain' to 'refrain'

2. added pointer to qualified relationships
@dr-shorthair
Copy link
Contributor

And I added another short paragraph providing a link to qualified-relation as a potential solution pathway.

@dr-shorthair dr-shorthair self-requested a review March 20, 2019 11:53
@dr-shorthair
Copy link
Contributor

Marked as non substantive for IPR from ash-nazg.

@dr-shorthair dr-shorthair added the critical defects that must be completed for CR label Mar 20, 2019
pwin
pwin previously requested changes Mar 22, 2019
Copy link
Contributor

@pwin pwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in second sentence - "relationshp" but otherwise is fine

Corrected typo "relationshp"
Copy link
Contributor

@davebrowning davebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo now addressed - looks good to go

@davebrowning davebrowning dismissed pwin’s stale review March 22, 2019 14:28

Issue (typo) now addressed

@davebrowning davebrowning merged commit 85c4ff3 into gh-pages Mar 26, 2019
@davebrowning davebrowning deleted the dcat-versioning-riccardo branch March 29, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical defects that must be completed for CR dcat versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants