Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial alignment to schema.org #140

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Initial alignment to schema.org #140

merged 1 commit into from
Mar 2, 2018

Conversation

dr-shorthair
Copy link
Contributor

Triggered by #65

@dr-shorthair dr-shorthair requested a review from a team February 28, 2018 23:00
davebrowning
davebrowning approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@davebrowning davebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me, though I'm not a schema.org expert. Given this is marked as provisional/incomplete but is needed as a basis for other work (and an example of modularisation) then I'm happy to approve for merge.

@dr-shorthair dr-shorthair mentioned this pull request Mar 1, 2018
Closed
@davebrowning davebrowning merged commit 22f4cff into gh-pages Mar 2, 2018
@davebrowning davebrowning deleted the simon-dcat-schemadotorg branch March 2, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davebrowning davebrowning davebrowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-shorthair @davebrowning