Dcat issue 1364 second solution #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t:theme, and changing a usage note
|
This looks clean and sensible to me |
riccardoAlbertoni
requested review from
agbeltran,
andrea-perego,
davebrowning and
pwin
|
@andrea-perego can you check the rephasing of the note before defining |
andrea-perego
requested changes
Jun 20, 2021
There was a problem hiding this comment.
Thanks, @riccardoAlbertoni .
+1 from me. I just suggested an editorial change.
Co-authored-by: Andrea Perego <[email protected]>
Thanks, Andrea. I have accepted your suggestion. |
andrea-perego
approved these changes
Jun 21, 2021
|
@davebrowning , @pwin , @agbeltran , Is this PR ok for you? |
davebrowning
approved these changes
Jun 23, 2021
riccardoAlbertoni
added a commit
that referenced
this pull request
Jun 23, 2021
…nd resolving the conflict with pr #1379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative solution to PR #1380
This PR drops the range for
dcat:theme, but explicitly defining it asowl:ObjectPropertyas suggested by @dr-shorthair in #1364 (comment)Considering that
dcterm:subjecthas been recently changed to let both literals and URI, by definingdcat:themes as anowl:ObjectPropertyand dropping thedcat:theme's range,dcat:themewould still restrictdcterms:subjectto URIs, whiledcat:keywordmight restrictdcterms:subjectto literals.This would also limit the automatic inference of
skos:Concept, which could be potentially problematic when applied to instances whose classes are defined disjoint fromskos:Concept.