Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String without the notion of a character #43

Closed
r12a opened this issue Mar 16, 2017 · 4 comments
Closed

String without the notion of a character #43

r12a opened this issue Mar 16, 2017 · 4 comments
Labels
Commenter Satisfied i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.

Comments

@r12a
Copy link

r12a commented Mar 16, 2017

[comment from @fsasaki ]
5. On string-based constraints components This section
http://w3c.github.io/data-shapes/shacl/#core-components-string

defines the length of a string, without the notion of a character.

Probably the implementations will just rely on SPARQL 1.1. here as well, but this should be pointed out explicitly, see the language matching comment.

[additional comment from i18n telecon]
Don't base 'character' on 16-bit code units. Use Unicode code points.
@r12a r12a added the i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. label Mar 16, 2017
@r12a r12a mentioned this issue Mar 16, 2017
Closed
@HolgerKnublauch
Copy link
Contributor

In the textual definitions of sh:maxLength and sh:minLength, we do have hyperlinks to the SPARQL 1.1 str function, which handles this. Again, I am not convinced that anything else needs to be said here, and welcome group discussion.

@fsasaki
Copy link

fsasaki commented Mar 18, 2017

I guess you mean the hyperlink in this sentence.

For each value node v where the length of the string representation of v (as defined by the SPARQL str function) is greater than $maxLength, or where v is a blank node, there is a validation result with v as sh:value.

I would see a value in making the notion of a string more explicit. See also the additional comment

Don't base 'character' on 16-bit code units. Use Unicode code points.

HolgerKnublauch added a commit that referenced this issue Mar 22, 2017
@HolgerKnublauch
Issue #43: sh:minLength and sh:maxLength now use SPARQL STRLEN functi…
ad91b8d 
…on explicitly
@HolgerKnublauch
Copy link
Contributor

We have added a reference to the SPARQL STRLEN function to clarify the semantics, see https://www.w3.org/2017/03/22-shapes-minutes.html#item04

@fsasaki
Copy link

fsasaki commented Mar 22, 2017

IMO looks good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Commenter Satisfied i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HolgerKnublauch @fsasaki @r12a