Making it easier to handle the state of extendable events#1348
Merged
Conversation
Contributor
Author
|
This has made it possible to monitor the progress of extendable events in other specs http://localhost:8080/background-fetch/#background-fetch-update-ui-event-update-ui. |
jungkees
approved these changes
Sep 12, 2018
jungkees
left a comment
jungkees
left a comment
Collaborator
There was a problem hiding this comment.
I like how it's referenced in the Background Fetch spec and also how it makes it easier to read the spec. Let's backport it to V1 too.
Contributor
Author
|
lol I linked to localhost. Thanks for not making fun of me. |
Contributor
Author
|
For my own reference, here's an easy way to lift changes from the living spec to v1: git diff master -- docs/index.bs | patch -p1 docs/v1/index.bs(assuming you're on a feature branch based on master) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's impossible for another spec to know if an extendable event is in progress, or what the result was afterwards.
I intended to just mark some things as "export", but tried to tidy up the useage along the way.
ExtendableEvent's extend lifetime promises is now exported.ExtendableEventnow has a timed out flag, which makes the user agent timeout a little more formal and detectable by other specs.ExtendableEventnow has an active 'getter', which indicates the event is in progress.If this is ok, I'll make the same changes in v1.
Preview | Diff