Correct record value serialization in cursor iteration #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveBeckerMSFT
commented
May 1, 2025
| 1. If |cursor|'s [=cursor/key only flag=] is false, then: | ||
|
|
||
| 1. Let |serialized| be |found record|'s [=index/referenced value=]. | ||
| 1. Let |serialized| be |found record|'s [=/value=] if |source| is an [=/object store=], or |found record|'s [=index/referenced value=] otherwise. |
Collaborator
Author
There was a problem hiding this comment.
Follow up question: Can this fail? Do we need error handling in these steps?
Member
There was a problem hiding this comment.
- If no record is found, then the cursor hits end of range. (current step 9.2)
- If a record is found, then it definitely has a value or referenced value (or the implementation has a bug)
- Right now the steps assert that
StructuredDeserializecan never fail. See Is it really true that StructuredDeserialize can't throw in this spec? #391 for potential concerns (so this is tracked elsewhere)
github-actions bot
added a commit
that referenced
this pull request
May 1, 2025
SHA: 896d5be Reason: push, by inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements @inexorabletash's suggestion to fix #452.
The following tasks have been completed:
Preview | Diff