Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Show/Hide toggle functionality #24

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Implemented Show/Hide toggle functionality #24

merged 2 commits into from
Jul 20, 2020

Conversation

morvy
Copy link
Contributor

@morvy morvy commented May 22, 2020

Description & Link to The Issue

Feature requested in issue #7

Javascript is partly rewritten (IC DPH logic), CSS for showing/hiding fields was added.

Bugfix: JS enqueued version was set to incorrect constant
Info: Slovak ICO has the same checksum algorithm as Czech, dropped SK function and replaced by CZ

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Design
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

This commit partly drops support for WooCommerce 3.4.x and below (3.4.7 has serious security issues, so it's time to upgrade anyway..) with Checkout Fields implementation.

Preview (Screenshot/Gif):

image
image
image
image

@morvy
Copy link
Contributor Author

morvy commented Jun 30, 2020

predpokladam, ze mate kopec inych veci na praci, ale nemali ste nahodou cas pozriet sa na toto? viem ze pracujete na verzii 2.0, tak ja len ci bude podobna funkcionalita pridana, pripadne ci ma zmysel tento PR

@vyskoczilova
Copy link
Owner

@morvy díky moc! Bohužel mi to zapadlo a verze 2.0 zdaleka není hotová.

Teď jsem to procházela a vypadá to dobře (díky moc!). Akorát ještě drobnost - pokud nepřemístím pole Země nahoru, ale nechám to, jak to je, a chci zobrazit "Nakupujete na firmu?", tak mi to dá checkbox mezi pole Jméno a Příjmení (a mělo by to asi jít až za Příjmení, v novém řádku), upravíte to ještě? Pak to hned pošlu ven s novým releasem.

image

Fix float:left na checkboxe Nakupuji na firmu pridanim triedy form-row-wide
@morvy
Copy link
Contributor Author

morvy commented Jul 19, 2020

Testoval som to na Storefront, kde mi to problem nerobilo, ale pravdepodobne chybalo form-row-wide (ktore sa stara o clear:both), tak snad fixnute, prosim Vas o kontrolu. Preklady poli predpokladam bude potrebne pridat na wp.org

Copy link
Owner

@vyskoczilova vyskoczilova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix funguje - na Twenty Twenty už se to zobrazuje, jak má. Díky moc, jdu to mergnout a poslat release. Překlady dodám.

@vyskoczilova vyskoczilova merged commit 76151ff into vyskoczilova:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants