Slovak DIC validation fix #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvy
commented
Jan 15, 2020
if IC is set, DIC must be set as well in Slovakia
vyskoczilova
requested changes
Jan 16, 2020
vyskoczilova
approved these changes
Jan 21, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Link to The Issue
Validácia SK DIČ (daňové identifikačné číslo) bola pri aktualizácii pluginu na verziu 1.4.0 opäť aktivovaná voči VIESu, čo nie je správne, nakoľko SK DIČ je len 10 miestne číslo bez "SK" prefixu. Tento commit pridáva výnimku pre kontrolu cez VIES (a odstraňuje duplicitnú kontrolu SoapClient). Taktiež podľa tohto článku je SK DIČ povinné a teda bola pridaná validácia tohto poľa a overenie cez už existujúcu funkcionalitu pluginu.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?