Skip to content

fix[lang]: disallow @raw_return in interfaces#4700

Merged
charles-cooper merged 1 commit intovyperlang:masterfrom
charles-cooper:test/raw-return-vyi
Jun 17, 2025
Merged

fix[lang]: disallow @raw_return in interfaces#4700
charles-cooper merged 1 commit intovyperlang:masterfrom
charles-cooper:test/raw-return-vyi

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper commented Jun 16, 2025 •
edited
Loading

What I did

How I did it

How to verify it

Commit message

this commit disallows `@raw_return` in `.vyi` files, as the decorator
doesn't have much semantic information for interfaces.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper marked this pull request as ready for review June 16, 2025 20:33
@charles-cooper charles-cooper added the release - must release blocker label Jun 16, 2025
@charles-cooper charles-cooper added this to the v0.4.3 milestone Jun 16, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (6b5a7e1) to head (72c083f).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4700   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files         131      131           
  Lines       19032    19034    +2     
  Branches     3307     3308    +1     
=======================================
+ Hits        17689    17691    +2     
  Misses        905      905           
  Partials      438      438

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pcaversaccio
pcaversaccio reviewed Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pcaversaccio pcaversaccio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nit but you can still compile successfully an interface file using vyper -f ast. Example:

# Itest.vyi
@raw_return
def foo(target: address) -> Bytes[128]:
    ...
vyper -f ast Itest.vyi

@charles-cooper
Copy link
Copy Markdown
Member Author

charles-cooper commented Jun 17, 2025

It's nit but you can still compile successfully an interface file using vyper -f ast. Example:

# Itest.vyi
@raw_return
def foo(target: address) -> Bytes[128]:
    ...
vyper -f ast Itest.vyi

yea, ast is pre-semantic analysis though - we are even considering dropping it: #4664

@charles-cooper charles-cooper merged commit 4efae6d into vyperlang:master Jun 17, 2025
164 checks passed
@charles-cooper charles-cooper deleted the test/raw-return-vyi branch June 17, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyberthirst cyberthirst cyberthirst approved these changes

@pcaversaccio pcaversaccio pcaversaccio approved these changes

Assignees

No one assigned

Labels

release - must release blocker

Projects

None yet

Milestone

v0.4.3

Development

Successfully merging this pull request may close these issues.

3 participants

@charles-cooper @cyberthirst @pcaversaccio