fix[venom]: fix function inliner clone function#4696
Merged
charles-cooper merged 2 commits intovyperlang:masterfrom Jun 17, 2025
Merged
fix[venom]: fix function inliner clone function#4696charles-cooper merged 2 commits intovyperlang:masterfrom
clone function#4696charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
rewrite the IRBasicBlock.parent pointer correctly. this is a well-formedness fix as it doesn't seem to be an observable bug at the moment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4696 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 131 131
Lines 19032 19032
Branches 3307 3307
=======================================
+ Hits 17689 17690 +1
+ Misses 905 904 -1
Partials 438 438 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harkal
approved these changes
Jun 17, 2025
charles-cooper
changed the title
clone function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite the IRBasicBlock.parent pointer correctly. this is a well-formedness fix as it doesn't seem to be an observable bug at the moment.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture