Skip to content

refactor[test]: rename venom param instruction in tests#4689

Merged
charles-cooper merged 5 commits intovyperlang:masterfrom
charles-cooper:refactor/venom/tests-param
Jun 16, 2025
Merged

refactor[test]: rename venom param instruction in tests#4689
charles-cooper merged 5 commits intovyperlang:masterfrom
charles-cooper:refactor/venom/tests-param

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

rename from param -> source, since we might actually need to test param sometimes.

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

rename from param -> source, since we might actually need to test param
sometimes.
Copy link
Copy Markdown
Collaborator

@harkal harkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (dd3dd77) to head (9b65b3d).
⚠️ Report is 34 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4689   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files         131      131           
  Lines       19030    19032    +2     
  Branches     3306     3307    +1     
=======================================
+ Hits        17687    17689    +2     
  Misses        905      905           
  Partials      438      438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper changed the title test[venom]: rename venom source instruction in tests refactor[venom]: rename venom source instruction in tests Jun 10, 2025
@charles-cooper charles-cooper marked this pull request as ready for review June 10, 2025 13:43
@charles-cooper charles-cooper enabled auto-merge (squash) June 16, 2025 18:02
@charles-cooper charles-cooper changed the title refactor[venom]: rename venom source instruction in tests refactor[test]: rename venom source instruction in tests Jun 16, 2025
@charles-cooper charles-cooper disabled auto-merge June 16, 2025 18:02
@charles-cooper charles-cooper changed the title refactor[test]: rename venom source instruction in tests refactor[test]: rename venom param instruction in tests Jun 16, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) June 16, 2025 18:03
@charles-cooper charles-cooper merged commit 6b5a7e1 into vyperlang:master Jun 16, 2025
161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants