Skip to content

feat[venom]: rewrite grammar to LALR(1)#4687

Merged
charles-cooper merged 6 commits intovyperlang:masterfrom
charles-cooper:feat/venom-lalr
Jun 17, 2025
Merged

feat[venom]: rewrite grammar to LALR(1)#4687
charles-cooper merged 6 commits intovyperlang:masterfrom
charles-cooper:feat/venom-lalr

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper commented Jun 9, 2025

What I did

fixes #4417

How I did it

How to verify it

Commit message

this commit updates the venom parser to use the LALR(1) algorithm,
which is O(n) rather than the O(n^3) earley algorithm.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 9, 2025

Codecov Report

❌ Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.93%. Comparing base (6b5a7e1) to head (96845dd).
⚠️ Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/parser.py 88.67% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4687      +/-   ##
==========================================
- Coverage   92.94%   92.93%   -0.01%     
==========================================
  Files         131      131              
  Lines       19032    19057      +25     
  Branches     3307     3314       +7     
==========================================
+ Hits        17689    17711      +22     
+ Misses        905      904       -1     
- Partials      438      442       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper requested a review from harkal June 10, 2025 14:15
@charles-cooper charles-cooper marked this pull request as ready for review June 10, 2025 14:16
@charles-cooper charles-cooper changed the title feat[venom]: rewrite to LALR(1) grammar feat[venom]: rewrite grammar to LALR(1) Jun 17, 2025
@charles-cooper charles-cooper merged commit 1d97d23 into vyperlang:master Jun 17, 2025
162 of 163 checks passed
@charles-cooper charles-cooper deleted the feat/venom-lalr branch June 17, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Venom parser uses slow earley algorithm

2 participants