fix[tool]: fix invalid quotes in -f cfg output#4672
Merged
charles-cooper merged 5 commits intovyperlang:masterfrom Jun 17, 2025
Merged
fix[tool]: fix invalid quotes in -f cfg output#4672charles-cooper merged 5 commits intovyperlang:masterfrom
-f cfg output#4672charles-cooper merged 5 commits intovyperlang:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4672 +/- ##
==========================================
+ Coverage 92.93% 92.95% +0.01%
==========================================
Files 131 131
Lines 19062 19062
Branches 3316 3316
==========================================
+ Hits 17716 17719 +3
Misses 904 904
+ Partials 442 439 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charles-cooper
added
the
release - tentative
charles-cooper
changed the title
cfg[_runtime] output
charles-cooper
changed the title
cfg[_runtime] output-f cfg output
charles-cooper
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The subgraph labels of the IR contain duplicate double quotes
""for the internal nodes which create a syntax error when parsing the generated output with graphviz. As a fix, I removed the duplicates so that the output only contains"now and can be used with graphviz again.How I did it
Changed the string interpolation of the subgraph label
How to verify it
Run tests or manually pipe the compiler output
cfg_runtimeformat intodot:Commit message
Description for the changelog
Remove duplicate quotes in subgraph labels which created a syntax error in the dot output
Cute Animal Picture