Skip to content

fix[tool]: add metadata for ctor functions#4668

Merged
charles-cooper merged 5 commits intovyperlang:masterfrom
charles-cooper:fix/metadata-only-ctor-reachable
Jun 17, 2025
Merged

fix[tool]: add metadata for ctor functions#4668
charles-cooper merged 5 commits intovyperlang:masterfrom
charles-cooper:fix/metadata-only-ctor-reachable

Conversation

@charles-cooper
Copy link
Copy Markdown
Member

@charles-cooper charles-cooper commented May 28, 2025

What I did

How I did it

How to verify it

Commit message

this commit adds metadata for functions which are only reachable from
the ctor.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

add metadata for functions which are only reachable from ctor.
@charles-cooper charles-cooper marked this pull request as ready for review May 28, 2025 17:35
@charles-cooper charles-cooper added the release - must release blocker label May 28, 2025
@charles-cooper charles-cooper added this to the v0.4.2 milestone May 28, 2025
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's please add a test for a call of init function from another init function

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also a test where an internal function gets called both from init and from some other external function

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link
Copy Markdown

codecov bot commented May 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (6b5a7e1) to head (36553f2).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4668   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files         131      131           
  Lines       19032    19035    +3     
  Branches     3307     3308    +1     
=======================================
+ Hits        17689    17692    +3     
  Misses        905      905           
  Partials      438      438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper added release - tentative items still being considered for release inclusion and removed release - must release blocker labels Jun 16, 2025
@charles-cooper charles-cooper modified the milestones: v0.4.2, v0.4.3 Jun 16, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) June 17, 2025 09:38
@charles-cooper charles-cooper merged commit 94750db into vyperlang:master Jun 17, 2025
159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release - tentative items still being considered for release inclusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants