feat[tool]: add venom artifacts into solc_json output#4637
Merged
charles-cooper merged 15 commits intovyperlang:masterfrom May 29, 2025
Merged
feat[tool]: add venom artifacts into solc_json output#4637charles-cooper merged 15 commits intovyperlang:masterfrom
solc_json output#4637charles-cooper merged 15 commits intovyperlang:masterfrom
Conversation
…iled result when calling compile_json()
Comment on lines
+57
to
+60
| translate_map.remove("bb") | ||
| translate_map.remove("bb_runtime") | ||
| translate_map.remove("cfg") | ||
| translate_map.remove("cfg_runtime") |
Member
There was a problem hiding this comment.
style, bit more compact:
Suggested change
| translate_map.remove("bb") | |
| translate_map.remove("bb_runtime") | |
| translate_map.remove("cfg") | |
| translate_map.remove("cfg_runtime") | |
| venom_outputs = ("bb", "bb_runtime", "cfg", "cfg_runtime") | |
| for s in venom_outputs: | |
| translate_map.remove(s) |
vyper/cli/vyper_json.py
Outdated
|
|
||
| outputs = sorted(list(outputs)) | ||
| if not input_dict["settings"].get("venom") and not input_dict["settings"].get("experimentalCodegen"): | ||
| for key in ["bb", "bb_runtime", "cfg", "cfg_runtime"]: |
Member
There was a problem hiding this comment.
maybe extract this list to a top level variable
vyper/cli/vyper_json.py
Outdated
| if "source_map_runtime" in data: | ||
| evm["sourceMap"] = data["source_map_runtime"] | ||
|
|
||
| venom_keys = ("bb", "bb_runtime", "cfg", "cfg_runtime",) |
Member
There was a problem hiding this comment.
ditto -- venom_keys could be top level variable
charles-cooper
changed the title
solc_json output
Member
|
this lgtm, @cyberthirst please take a look |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4637 +/- ##
==========================================
+ Coverage 92.79% 92.92% +0.13%
==========================================
Files 131 131
Lines 18973 18991 +18
Branches 3288 3295 +7
==========================================
+ Hits 17606 17648 +42
+ Misses 934 905 -29
- Partials 433 438 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyberthirst
reviewed
May 26, 2025
| "search_paths": [], | ||
| "outputSelection": {"*": ["ast"]}, | ||
| "search_paths": ["."], | ||
| "outputSelection": {"*": ["ast", "bb", "bb_runtime", "cfg", "cfg_runtime"]}, |
Collaborator
There was a problem hiding this comment.
ast is not tested for
cyberthirst
reviewed
May 27, 2025
vyper/cli/vyper_json.py
Outdated
| input_dict["settings"].get(alias, False) for alias in ("venom", "experimentalCodegen") | ||
| ) | ||
| if not should_output_venom: | ||
| outputs = [k for k in outputs if k not in VENOM_KEYS] |
Collaborator
There was a problem hiding this comment.
so some venom key was requested, but we silently ignore the request and don't output it. i'd expected that incompatible options would rather raise
cyberthirst
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I added the venom optimizer keys
['bb', 'bb_runtime', 'cfg', 'cfg_runtime']into the compiled output when callingcompile_json()How I did it
Adapted the translate map and guarded it with the
venomflagHow to verify it
Added tests inside
test_compile_json.pyCommit message
Description for the changelog
['bb', 'bb_runtime', 'cfg', 'cfg_runtime']Cute Animal Picture