fix[lang]: disallow duplicate getter annotations#4623
Merged
charles-cooper merged 3 commits intovyperlang:masterfrom May 1, 2025
Merged
fix[lang]: disallow duplicate getter annotations#4623charles-cooper merged 3 commits intovyperlang:masterfrom
charles-cooper merged 3 commits intovyperlang:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4623 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 128 128
Lines 18521 18525 +4
Branches 3210 3211 +1
=======================================
+ Hits 17131 17135 +4
Misses 945 945
Partials 445 445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| def test_duplicate_public_annotation(): | ||
| code = """ | ||
| a: public(public(uint256)) |
Member
There was a problem hiding this comment.
how about transient(transient(uint256))?
or for that matter, transient(constant(immutable(uint256))) 🤔
Member
There was a problem hiding this comment.
charles-cooper
changed the title
charles-cooper
approved these changes
Apr 30, 2025
Collaborator
Author
|
updates to the tests are lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Commit message
How to verify it