fix[venom]: fix DominatorTreeAnalysis.dominates()#4615
Merged
charles-cooper merged 2 commits intovyperlang:masterfrom Apr 28, 2025
Merged
fix[venom]: fix DominatorTreeAnalysis.dominates()#4615charles-cooper merged 2 commits intovyperlang:masterfrom
DominatorTreeAnalysis.dominates()#4615charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
the arguments were switched. this was unnoticed before since `dominates()` was unused, but is wrong if you want to use `dominates()` API instead of accessing the `.dominators` data structure directly
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4615 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 128 128
Lines 18506 18506
Branches 3208 3208
=======================================
Hits 17118 17118
Misses 944 944
Partials 444 444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harkal
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the arguments were switched. this was unnoticed before since
dominates()was unused, but is wrong if you want to usedominates()API instead of accessing the.dominatorsdata structure directlyWhat I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture