chore[lang]: remove sha3 and importlib_metadata imports#4588
Merged
charles-cooper merged 4 commits intovyperlang:masterfrom Apr 22, 2025
Merged
chore[lang]: remove sha3 and importlib_metadata imports#4588charles-cooper merged 4 commits intovyperlang:masterfrom
sha3 and importlib_metadata imports#4588charles-cooper merged 4 commits intovyperlang:masterfrom
Conversation
since we have `pycryptodome` as a requirement, the sha3 import is dead. additionally, pysha3 is no longer maintained.
importlib.metadata is no longer provisional as of Python3.10, so we can remove the backported version.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4588 +/- ##
==========================================
+ Coverage 92.68% 92.70% +0.02%
==========================================
Files 123 123
Lines 17575 17570 -5
Branches 2988 2988
==========================================
Hits 16289 16289
+ Misses 888 883 -5
Partials 398 398 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fubuloubu
approved these changes
Apr 21, 2025
cyberthirst
approved these changes
Apr 22, 2025
charles-cooper
changed the title
charles-cooper
changed the title
charles-cooper
changed the title
sha3 and importlib_metadata imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since we have
pycryptodomeas a requirement, the sha3 import is dead. additionally, pysha3 is no longer maintained.What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture