fix[venom]: fix handling of params in venom_to_assembly#4587
Merged
charles-cooper merged 8 commits intovyperlang:masterfrom Apr 27, 2025
Merged
fix[venom]: fix handling of params in venom_to_assembly#4587charles-cooper merged 8 commits intovyperlang:masterfrom
venom_to_assembly#4587charles-cooper merged 8 commits intovyperlang:masterfrom
Conversation
previously, params were handled one at a time. however, steps 4 and 6
could POP or SWAP the params while traversing the param list, which is
invalid since the stack is in an invalid state. for example,
```
function foo {
%1 = param ; dead variable
; --> POP inserted here! <--
%2 = param
%3 = param ; %3 is scheduled before %2
; --> SWAP inserted here! <--
%4 = param
mstore %4, %3
ret %2
}
```
this was previously not visible because of how ir_node_to_venom
generates params; they are very well-behaved (and always live).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
- Coverage 92.44% 92.43% -0.01%
==========================================
Files 127 127
Lines 18304 18327 +23
Branches 3173 3179 +6
==========================================
+ Hits 16921 16941 +20
- Misses 946 947 +1
- Partials 437 439 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harkal
approved these changes
Apr 27, 2025
venom_to_assembly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture