fix[venom]: revert-to-assert should invalidate dfg#4586
Merged
charles-cooper merged 2 commits intovyperlang:masterfrom Apr 22, 2025
Merged
fix[venom]: revert-to-assert should invalidate dfg#4586charles-cooper merged 2 commits intovyperlang:masterfrom
charles-cooper merged 2 commits intovyperlang:masterfrom
Conversation
the revert-to-assert pass should invalidate the dfg. since cfg invalidation already invalidates the dfg, this commit is just for hygiene.
harkal
approved these changes
Apr 19, 2025
HodanPlodky
reviewed
Apr 22, 2025
| self._rewrite_jnz(pred, bb) | ||
|
|
||
| self.analyses_cache.invalidate_analysis(CFGAnalysis) | ||
| self.analyses_cache.invalidate_analysis(DFGAnalysis) |
Collaborator
There was a problem hiding this comment.
You forgot to import DFGAnalysis
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4586 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 123 123
Lines 17575 17576 +1
Branches 2988 2988
=======================================
+ Hits 16289 16290 +1
Misses 888 888
Partials 398 398 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HodanPlodky
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the revert-to-assert pass should invalidate the dfg. since cfg invalidation already invalidates the dfg, this commit is just for hygiene.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture